test: Fix rpc_net intermittent issue #20214

1. 
   MarcoFalke commented at 7:08 pm on October 21, 2020: member

   Without the sync, the nodes might generate blocks at the same height and thus never be able to sync
2. test: Fix rpc_net intermittent issue fa5f46600f
3. 
   MarcoFalke commented at 7:09 pm on October 21, 2020: member

   Example: https://cirrus-ci.com/task/4539922524667904?command=ci#L6426
4. DrahtBot added the label Tests on Oct 21, 2020
5. 
   practicalswift commented at 8:21 pm on October 21, 2020: contributor

   ACK fa5f46600fb98f1b35346bedc1a66c9019d01114: patch looks correct

   Thanks for fixing flaky tests :)

6. 
   promag commented at 11:55 pm on October 21, 2020: member

   ACK.

   Most sync_all are after connect_nodes+ and stuff like send/generate/make_utxo. Maybe we could warn if sync_all is not called right after these cases.

7. fanquake merged this on Oct 22, 2020
8. fanquake closed this on Oct 22, 2020

   ---

9. sidhujag referenced this in commit b7b2657b16 on Oct 22, 2020
10. MarcoFalke deleted the branch on Oct 22, 2020
11. DrahtBot locked this on Feb 15, 2022

Contributors
MarcoFalke practicalswift promag

Labels
Tests