Without the sync, the nodes might generate blocks at the same height and thus never be able to sync
test: Fix rpc_net intermittent issue #20214
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2010-testFixNet changing 1 files +1 −0-
MarcoFalke commented at 7:08 PM on October 21, 2020: member
-
test: Fix rpc_net intermittent issue fa5f46600f
-
MarcoFalke commented at 7:09 PM on October 21, 2020: member
- DrahtBot added the label Tests on Oct 21, 2020
-
practicalswift commented at 8:21 PM on October 21, 2020: contributor
ACK fa5f46600fb98f1b35346bedc1a66c9019d01114: patch looks correct
Thanks for fixing flaky tests :)
-
promag commented at 11:55 PM on October 21, 2020: member
ACK.
Most sync_all are after connect_nodes+ and stuff like send/generate/make_utxo. Maybe we could warn if sync_all is not called right after these cases.
- fanquake merged this on Oct 22, 2020
- fanquake closed this on Oct 22, 2020
- sidhujag referenced this in commit b7b2657b16 on Oct 22, 2020
- MarcoFalke deleted the branch on Oct 22, 2020
- DrahtBot locked this on Feb 15, 2022
Contributors
Labels