net: compat.h related cleanup #20221

pull hebasto wants to merge 3 commits into bitcoin:master from hebasto:201022-compat changing 4 files +2 −17
  1. hebasto commented at 5:04 pm on October 22, 2020: member
    It is the compat.h header’s job to provide platform-agnostic interfaces for internet operations. No need in #include <arpa/inet.h> scattered around.
  2. hebasto commented at 5:06 pm on October 22, 2020: member
  3. practicalswift commented at 6:06 pm on October 22, 2020: contributor
    ACK 3da5a27ca3290b05b50453295304d35f5ac729f7: patch looks correct
  4. net: Drop unneeded Windows headers in compat.h
    No interface from the mswsock.h header is used.
    According to https://docs.microsoft.com/en-us/windows/win32/winsock/creating-a-basic-winsock-application
    "The Winsock2.h header file internally includes core elements from
    the Windows.h header file, so there is not usually an #include line
    for the Windows.h header file in Winsock applications."
    467c346448
  5. net: Drop unneeded headers when compat.h included f796f0057b
  6. net: Add compat.h header for htonl function cadb77a6ab
  7. hebasto force-pushed on Oct 22, 2020
  8. hebasto commented at 6:46 pm on October 22, 2020: member
    Removed trailing space.
  9. practicalswift commented at 6:54 pm on October 22, 2020: contributor
    re-ACK cadb77a6ab8a3e6f56062cfaec4dd8168c71b39d: patch looks even better
  10. DrahtBot added the label P2P on Oct 22, 2020
  11. DrahtBot added the label RPC/REST/ZMQ on Oct 22, 2020
  12. DrahtBot commented at 6:16 pm on November 3, 2020: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    No conflicts as of last run.

  13. laanwj commented at 1:54 pm on December 3, 2020: member
    Code review ACK cadb77a6ab8a3e6f56062cfaec4dd8168c71b39d
  14. laanwj merged this on Dec 3, 2020
  15. laanwj closed this on Dec 3, 2020

  16. hebasto deleted the branch on Dec 3, 2020
  17. sidhujag referenced this in commit 8fb0ba6ed9 on Dec 3, 2020
  18. Fabcien referenced this in commit ca2f8da4cb on Feb 7, 2022
  19. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-03 10:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me