test: Run script_assets_test even if built --with-libs=no #20245

pull MarcoFalke wants to merge 3 commits into bitcoin:master from MarcoFalke:2010-testAssetTestlibconsensus changing 2 files +12 −11

MarcoFalke commented at 1:29 PM on October 26, 2020: member

script_assets_test doesn't call libbitcoinconsensus, so it seems confusing to require it
ci: Add --with-libs=no to one ci config faf58ab139
test: Run AssetTest even if built --with-libs=no fafc529053
test: Replace ARRAYLEN with C++11 ranged for loop fa3967efdb
DrahtBot added the label Tests on Oct 26, 2020
DrahtBot commented at 3:58 PM on October 26, 2020: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #19013 (test: add v0.20.1 to backwards compatibility test by Sjors)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
fanquake approved
fanquake commented at 2:13 PM on October 27, 2020: member

ACK fa3967efdb07f1d22372f4ee2e602ea1fad04a57 - looks ok to me.
MarcoFalke merged this on Nov 4, 2020
MarcoFalke closed this on Nov 4, 2020
MarcoFalke deleted the branch on Nov 4, 2020
sidhujag referenced this in commit 1c8919c44d on Nov 4, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels