Update secp256k1 subtree to latest master #20257

sipa commented at 6:15 AM on October 28, 2020: member

Nothing important changed, but this silences this (erroneous) warning in certain GCC 9 versions:

In file included from src/secp256k1.c:16:
src/ecmult_impl.h: In function ‘secp256k1_ecmult’:
src/ecmult_impl.h:496:48: warning: array subscript [1, 268435456] is outside array bounds of ‘struct secp256k1_strauss_point_state[1]’ [-Warray-bounds]
  496 |             secp256k1_gej tmp = a[state->ps[np].input_pos];
      |                                   ~~~~~~~~~~~~~^~~~~~~~~~
src/ecmult_impl.h:565:42: note: while referencing ‘ps’
  565 |     struct secp256k1_strauss_point_state ps[1];
      |                                          ^~
src/ecmult_impl.h:502:139: warning: array subscript [1, 268435456] is outside array bounds of ‘struct secp256k1_strauss_point_state[1]’ [-Warray-bounds]
  502 |             secp256k1_fe_mul(state->zr + np * ECMULT_TABLE_SIZE(WINDOW_A), state->zr + np * ECMULT_TABLE_SIZE(WINDOW_A), &(a[state->ps[np].input_pos].z));
      |                                                                                                                              ~~~~~~~~~~~~~^~~~~~~~~~
src/ecmult_impl.h:565:42: note: while referencing ‘ps’
  565 |     struct secp256k1_strauss_point_state ps[1];
      |                                          ^~

(see https://github.com/bitcoin-core/secp256k1/issues/834)

Squashed 'src/secp256k1/' changes from c6b6b8f1bb..3967d96bf1

3967d96bf1 Merge #838: Make autotools check for all the used openssl functions
3734b68200 Configure echo if openssl tests are enabled
6f54e69f03 Merge #841: Avoids a potentially shortening size_t to int cast in strauss_wnaf_
8893f42438 Avoids a potentially shortening size_t to int cast in strauss_wnaf_
e6692778d3 Modify bitcoin_secp.m4's openssl check to call all the functions that we use in the tests/benchmarks. That way linking will fail if those symbols are missing
ac05f61fcf Merge #809: Stop treating ECDH as experimental
e6e3d5da2f travis: add schnorrsig to valgrind and big endian platform test
353dff156f Stop treating ECDH as experimental

git-subtree-dir: src/secp256k1
git-subtree-split: 3967d96bf184519eb98b766af665b4d4b072563e

6c0259fc2f

Update secp256k1 subtree to latest master 5803f5f5f6

fanquake added the label Upstream on Oct 28, 2020

fanquake approved

fanquake commented at 8:34 AM on October 28, 2020: member

ACK 5803f5f5f6030e69b46a46f0511b8173bf89de0d - performed the update myself and got the same change: check_20257_subtree.

Tested master & this PR on Ubuntu with GCC 9.3.0. I think it's worth doing this to remove the warning output and save the spurious bug reports.

master:

  CC       src/libsecp256k1_la-secp256k1.lo
  CXX      node/libbitcoin_server_a-coinstats.o
In file included from src/secp256k1.c:16:
src/ecmult_impl.h: In function 'secp256k1_ecmult':
src/ecmult_impl.h:496:48: warning: array subscript [1, 268435456] is outside array bounds of 'struct secp256k1_strauss_point_state[1]' [-Warray-bounds]
  496 |             secp256k1_gej tmp = a[state->ps[np].input_pos];
      |                                   ~~~~~~~~~~~~~^~~~~~~~~~
src/ecmult_impl.h:565:42: note: while referencing 'ps'
  565 |     struct secp256k1_strauss_point_state ps[1];
      |                                          ^~
src/ecmult_impl.h:502:139: warning: array subscript [1, 268435456] is outside array bounds of 'struct secp256k1_strauss_point_state[1]' [-Warray-bounds]
  502 |             secp256k1_fe_mul(state->zr + np * ECMULT_TABLE_SIZE(WINDOW_A), state->zr + np * ECMULT_TABLE_SIZE(WINDOW_A), &(a[state->ps[np].input_pos].z));
      |                                                                                                                              ~~~~~~~~~~~~~^~~~~~~~~~
src/ecmult_impl.h:565:42: note: while referencing 'ps'
  565 |     struct secp256k1_strauss_point_state ps[1];
      |                                          ^~
  CCLD     libsecp256k1.la

hebasto approved

hebasto commented at 9:40 AM on October 28, 2020: member

ACK 5803f5f5f6030e69b46a46f0511b8173bf89de0d, tested on Linux Mint 20 (x86_64) with gcc (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0 -- no warnings are emitted.

fanquake merged this on Oct 29, 2020

fanquake closed this on Oct 29, 2020

sidhujag referenced this in commit fc69064dca on Oct 29, 2020

zkbot referenced this in commit cbc475fd48 on Apr 8, 2021

UdjinM6 referenced this in commit ee2a08fe89 on Aug 10, 2021

5tefan referenced this in commit 9ddb79318d on Aug 12, 2021

DrahtBot locked this on Feb 15, 2022