fuzz: Check for addrv1 compatibility before using addrv1 serializer/deserializer on CService #20289

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:fuzzers-service_deserialize-addrv2 changing 1 files +4 −1

practicalswift commented at 9:50 PM on November 2, 2020: contributor

Check for addrv1 compatibility before using addrv1 serializer/deserializer on CService:

Before this patch:

$ src/test/fuzz/service_deserialize
service_deserialize: test/fuzz/deserialize.cpp:85:
    void (anonymous namespace)::AssertEqualAfterSerializeDeserialize(const T &, const int) [T = CService]:
    Assertion `Deserialize<T>(Serialize(obj, version)) == obj' failed.

After this patch:

$ src/test/fuzz/service_deserialize
…

Related change: #20247

fuzz: Check for addrv1 compatibility before using addrv1 serializer on CService c2cf8a18c2
DrahtBot added the label Tests on Nov 2, 2020
MarcoFalke commented at 8:13 AM on November 3, 2020: member

review ACK c2cf8a18c25bf19ade51fedfa5c352bd7145edb0
MarcoFalke merged this on Nov 3, 2020
MarcoFalke closed this on Nov 3, 2020
sidhujag referenced this in commit ac6844bafc on Nov 3, 2020

MarcoFalke commented at 1:28 PM on November 9, 2020: member

Why not fix ./src/test/fuzz/sub_net_deserialize as well?

sub_net_deserialize: test/fuzz/deserialize.cpp:85: void (anonymous namespace)::AssertEqualAfterSerializeDeserialize(const T &, const int) [T = CSubNet]: Assertion `Deserialize<T>(Serialize(obj, version)) == obj' failed.

practicalswift commented at 3:37 PM on November 9, 2020: contributor

@MarcoFalke Fixed in #20355.
MarcoFalke referenced this in commit 0b69bb90ee on Nov 10, 2020
sidhujag referenced this in commit 929abcfe2d on Nov 10, 2020
practicalswift deleted the branch on Apr 10, 2021
PastaPastaPasta referenced this in commit 0e77bfd548 on Sep 17, 2021
PastaPastaPasta referenced this in commit 95ecc8fb7d on Sep 19, 2021
PastaPastaPasta referenced this in commit 2bf2fa8751 on Sep 21, 2021
PastaPastaPasta referenced this in commit f5be380db7 on Sep 24, 2021
kittywhiskers referenced this in commit 4d09e2cdd6 on Oct 12, 2021
DrahtBot locked this on Aug 18, 2022

Contributors

practicalswift

MarcoFalke

Labels

Tests

Linked (view graph)

#20247 fuzz: Check for addrv1 compatibility before using addrv1 serializer. Fuzz addrv2 serialization.#20355 fuzz: Check for addrv1 compatibility before using addrv1 serializer/deserializer on CSubNet