fuzz: Add missing ECC_Start to descriptor_parse test #20300

pull S3RK wants to merge 1 commits into bitcoin:master from S3RK:fix_fuzz_descriptor_parse changing 1 files +2 −1

S3RK commented at 2:08 PM on November 4, 2020: member

Fixes fuzzing harness.

I also observed that the corpus for this test consists only of xprv... keys while we are using regtest parameters. So for proper fuzzing we need either A) to update the corpus and replace xprv... with tprv... B) switch to main net in the test
fanquake added the label Tests on Nov 4, 2020
MarcoFalke commented at 3:03 PM on November 4, 2020: member

Mind submitting a patch with the new seeds you found?

in src/test/fuzz/descriptor_parse.cpp:15 in 167616b98e outdated

  10 | @@ -11,6 +11,7 @@
  11 |  void initialize()
  12 |  {
  13 |      static const ECCVerifyHandle verify_handle;
  14 | +    ECC_Start();
  15 |      SelectParams(CBaseChainParams::REGTEST);

MarcoFalke commented at 3:12 PM on November 4, 2020:

    SelectParams(CBaseChainParams::MAIN);

or alternatively change this to MAIN

S3RK commented at 3:55 PM on November 4, 2020:

done

fuzz: Add missing ECC_Start to descriptor_parse test 5cafe2b25c
S3RK force-pushed on Nov 4, 2020
S3RK commented at 3:57 PM on November 4, 2020: member

Mind submitting a patch with the new seeds you found?

Let me recompile first with the new chain params and let it run for a while. I'll submit new seeds if found
MarcoFalke commented at 4:03 PM on November 4, 2020: member

review ACK 5cafe2b25c1d2f6825b3c8103c280020929dd645

the seeds dir should already contain seeds for mainnet, as I remember having them added at some point.
practicalswift commented at 5:55 PM on November 4, 2020: contributor

Tested ACK 5cafe2b25c1d2f6825b3c8103c280020929dd645

Always super happy to see proof of fuzzing like this case: love seeing fuzzing enthusiasts joining in the quest for making Bitcoin Core even more robust! Thanks @S3RK! :)
MarcoFalke merged this on Nov 4, 2020
MarcoFalke closed this on Nov 4, 2020
sidhujag referenced this in commit bfde8b10a3 on Nov 5, 2020
S3RK deleted the branch on Dec 26, 2020
S3RK restored the branch on Dec 26, 2020
S3RK deleted the branch on Dec 26, 2020
S3RK restored the branch on Dec 26, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels