Make it easier to reason about node eviction by removing unused NodeEvictionCandidate::addr (CAddress).
net: Make it easier to reason about node eviction by removing unused NodeEvictionCandidate::addr (CAddress) #20302
pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:NodeEvictionCandidate-addr changing 1 files +1 −2-
practicalswift commented at 4:57 PM on November 4, 2020: contributor
-
Make it easier to reason about node eviction by removing unused NodeEvictionCandidate::addr (CAddress) f1f433e8ca
- DrahtBot added the label P2P on Nov 4, 2020
-
amitiuttarwar commented at 6:53 PM on November 4, 2020: contributor
ack f1f433e8ca
very simple change. the addr field indeed seems unused. eviction logic is plenty complicated without red herrings.
-
DrahtBot commented at 10:58 PM on November 4, 2020: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #20197 (p2p: improve onion detection in AttemptToEvictConnection() by jonatack)
- #19972 (tests/net: Add fuzzing harness for node eviction logic. Make node eviction logic testable. by practicalswift)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- MarcoFalke added the label Refactoring on Nov 5, 2020
-
jnewbery commented at 10:06 AM on November 5, 2020: member
utACK f1f433e8ca014f69925e8d5487877e06ca784ec8
Thanks for removing unused variables from this confusing piece of code!
- MarcoFalke merged this on Nov 5, 2020
- MarcoFalke closed this on Nov 5, 2020
- sidhujag referenced this in commit 26d5b65bc8 on Nov 5, 2020
- practicalswift deleted the branch on Apr 10, 2021
- Fabcien referenced this in commit 8d18902f61 on Jun 15, 2021
- DrahtBot locked this on Aug 18, 2022
Contributors
Labels