security-check.py is using wrong comparison operators #20338

./contrib/devtools/security-check.py:65: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if splitline[ofs_flags + 1] is 'E':
./contrib/devtools/security-check.py:65: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if splitline[ofs_flags + 1] is 'E':
./contrib/devtools/security-check.py:65: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if splitline[ofs_flags + 1] is 'E':
./contrib/devtools/security-check.py:65: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if splitline[ofs_flags + 1] is 'E':
./contrib/devtools/security-check.py:65: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if splitline[ofs_flags + 1] is 'E':
./contrib/devtools/security-check.py:65: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if splitline[ofs_flags + 1] is 'E':

See also:

>>> 'asdf'[:2] == 'as'
True
>>> 'asdf'[:2] is 'as'
<stdin>:1: SyntaxWarning: "is" with a literal. Did you mean "=="?
False

Have we discussed using checksec.py (which uses the excellent LIEF library) instead?

https://pypi.org/project/checksec.py/

I've used checksec.py and I find it more robust and well-maintained.

Ouch, I now saw that checksec.py is a non-starter (GPLv3). Never mind!

This is new in 3.8+. The above small fix should fix the problem (couldn't find any other occurrences).