Descriptor Wallets BIP39 recovery #20361

pull ghost wants to merge 5 commits into bitcoin:master from changing 13 files +459 −21

ghost commented at 7:37 AM on November 10, 2020: none

./src/bitcoin-cli sethdseed true "ffffffffffffffffffffffffffffffff" hex ./src/bitcoin-cli sethdseed true "zoo zoo zoo zoo zoo zoo zoo zoo zoo zoo zoo wrong" mnemonic

works only for new type of wallet
fanquake added the label Wallet on Nov 10, 2020
DrahtBot added the label Needs rebase on Nov 10, 2020
DrahtBot removed the label Needs rebase on Nov 10, 2020
DrahtBot commented at 3:01 AM on November 11, 2020: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #20391 (wallet: introduce setfeerate (an improved settxfee, in sat/vB) by jonatack)
- #20305 (wallet: introduce fee_rate sat/vB param/option by jonatack)
- #16546 (External signer support - Wallet Box edition by Sjors)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
luke-jr commented at 6:33 PM on November 13, 2020: member

if you have seed words enter them in https://iancoleman.io/bip39/ and get the entropy (Show entropy details)

Please don't encourage people to enter private seed information into web browsers!
unknown renamed this:
~~load wallets from entropy (as BIP39)~~
Descriptor Wallets BIP39 recovery
on Nov 15, 2020
achow101 commented at 5:29 PM on November 15, 2020: member

NACK

sethdseed should not be enabled for descriptor wallets. It completely destroys the purpose of using descriptor wallets because it will reintroduce the ambiguity about what kind of addresses are in the wallet. If you want to have BIP 39 in descriptors, then do BIP 39 in descriptors themselves. Users could then import a descriptor containing a BIP 39 seed via importdescriptors. Don't do this thing where we try to make descriptor wallets have an hd seed (they really don't) and then set that seed. That's a legacy wallet thing.
BIP39 7e6ba0a327
accept well formatted mnemonic 5839dd0518
windows fix 04d29f9f4e
move key_bip39 cc78c2195e
move key_bip39 7b68ba17e8
fanquake commented at 7:06 AM on November 16, 2020: member

just a weekend hack, but maybe if will be usefull for somebody

PR's opened against this repo should contain code that is ready to be reviewed by other contributors. If you're looking for conceptual review or want to discuss a new feature/idea, you can open a draft PR (this will avoid some of the notifications generated by our bot), or an issue. We'd also prefer if you didn't do your development by continually force-pushing to the branch, as that just spams anyone subscribed to the repository with emails.

Please also read CONTRIBUTING.md.
ghost commented at 9:17 AM on November 16, 2020: none

closing review, leaving as a patch for personal use if i will need to get access to BIP39 protected wallet
unknown closed this on Nov 16, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Descriptor Wallets BIP39 recovery #20361

Conflicts