refactor, net: Increase CNode data member encapsulation #20373

1. 
   hebasto commented at 5:13 pm on November 11, 2020: member

   All protected CNode data members could be private.
2. DrahtBot added the label P2P on Nov 11, 2020
3. hebasto force-pushed on Nov 11, 2020
4. DrahtBot added the label Needs rebase on Nov 11, 2020
5. 
   hebasto commented at 5:27 pm on November 11, 2020: member

   cc @troygiorshev @jnewbery
6. DrahtBot removed the label Needs rebase on Nov 11, 2020
7. 
   jnewbery commented at 8:01 pm on November 11, 2020: member

   Concept ACK making protected members private if they don’t need to be protected. I’ll review once #19673 is merged and this is rebased.
8. 
   practicalswift commented at 8:43 pm on November 11, 2020: contributor

   Concept ACK
9. 
   DrahtBot commented at 0:02 am on November 12, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   No conflicts as of last run.

10. 
    promag commented at 11:14 am on November 14, 2020: member

    Concept ACK.

    I’d drop the “consolidate” commit. But if it’s kept then it could be marked move-only. Also, there’s an unnecessary public:.

11. 
    sipa commented at 5:09 am on December 27, 2020: member

    utACK 75f7e47b3ae59b7a8b1f5ec86ac281403a50a604
12. 
    MarcoFalke commented at 8:51 am on December 27, 2020: member

    Tend to NACK for the same reason: #19673#pullrequestreview-557045721
13. DrahtBot added the label Needs rebase on Jan 2, 2021
14. 
    jnewbery commented at 9:43 am on January 6, 2021: member

    @hebasto could you rebase now that #20816 is merged?
15. hebasto force-pushed on Jan 9, 2021
16. 
    hebasto commented at 9:17 am on January 9, 2021: member

    Updated 75f7e47b3ae59b7a8b1f5ec86ac281403a50a604 -> 7f20edf4bb827a368b8eaf8d2c22643d5935c613 (pr20373.01 -> pr20373.02). @jnewbery

    @hebasto could you rebase now that #20816 is merged?

    Done. @promag

    … if it’s kept then it could be marked move-only.

    Done.

    Also, there’s an unnecessary public:.

    Fixed.

17. 
    jnewbery commented at 10:47 am on January 9, 2021: member

    ACK 7f20edf4bb827a368b8eaf8d2c22643d5935c613

    Verified that this is move-only, except for making the protected members private.

    Thanks for cleaning this up!

18. DrahtBot removed the label Needs rebase on Jan 9, 2021
19. DrahtBot added the label Needs rebase on Jan 10, 2021
20. refactor, move-only: Relocate CNode private members acebb79d3f
21. refactor, net: Increase CNode data member encapsulation

    All protected CNode data members could be private.

    3642b2ed34
22. hebasto force-pushed on Jan 10, 2021
23. 
    hebasto commented at 10:06 am on January 10, 2021: member

    Updated 7f20edf4bb827a368b8eaf8d2c22643d5935c613 -> 3642b2ed34e6609e8de558b352516daadb12cac1 (pr20373.02 -> pr20373.03) due to the conflict with #20881.
24. DrahtBot removed the label Needs rebase on Jan 10, 2021
25. 
    jnewbery commented at 10:40 am on January 11, 2021: member

    utACK 3642b2ed34e6609e8de558b352516daadb12cac1
26. 
    MarcoFalke commented at 12:09 pm on January 11, 2021: member

    review ACK 3642b2ed34e6609e8de558b352516daadb12cac1 🏛

    Signature:

     0-----BEGIN PGP SIGNED MESSAGE-----
     1Hash: SHA512
     2
     3review ACK 3642b2ed34e6609e8de558b352516daadb12cac1 🏛
     4-----BEGIN PGP SIGNATURE-----
     5
     6iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
     7pUgpSgwAiwjdT13xFBxwJQmARjPmO8p8A7XcH2TDGrYMjehHgN9z/c6LajnsGLrf
     8HxU581vUH1HnWmjnSFdlQOKC/IDRiUDw9ogpakbjVi4Z1+KJnXEwJCDoCQepAKGA
     9adpBXg1jZLbLXlyhsiladQb5mAEZ0Cbru8NnXIriUP0SFgM7RGR7EaP9G0BUVqYx
    103rpDxXtsUmtaZ7Y2/2SpTABh2UEK0ya1v1x8ILlWwz1YhqTEunSI8VwNffxCiVBn
    11V+oYGbKEyM/zg6x3MQnnX1plXgoz0XEOqmqqK12jtkTQAknWp7tQj7DhSCbSjLaS
    12ojE2LPFc5GhYDA0nvMq8N//Bm6yd6Z29WK5x8trAGmOEbpGxcyqrjN4Nnuw0O0Ai
    13hxt0XnQ6YMjeFvh5xzrIQEQwTd2bttrk6CiAf46hnwwmXwHbNwecTRQtj4+7LZlf
    14frOLEwBnFnQiOZjkiIXP0Q1L3pfQYKSNxr8b426QUBhQBNLojP+xBw4eLX3Gu3Iq
    15zSgvcVPd
    16=leU8
    17-----END PGP SIGNATURE-----
    

    Timestamp of file with hash a0e7b38da83edfebd9fb41f063e4ec58f924d3f47816589b67b81a023d3dcd94 -

27. MarcoFalke merged this on Jan 11, 2021
28. MarcoFalke closed this on Jan 11, 2021

    ---

29. hebasto deleted the branch on Jan 11, 2021
30. sidhujag referenced this in commit 5d6c7186ed on Jan 11, 2021
31. DrahtBot locked this on Aug 16, 2022

Contributors
hebasto jnewbery practicalswift DrahtBot promag sipa MarcoFalke

Labels
P2P