refactor, net: Increase CNode data member encapsulation #20373

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:201111-cnode changing 1 files +38 −45

hebasto commented at 5:13 PM on November 11, 2020: member

All protected CNode data members could be private.
DrahtBot added the label P2P on Nov 11, 2020
hebasto force-pushed on Nov 11, 2020
DrahtBot added the label Needs rebase on Nov 11, 2020
hebasto commented at 5:27 PM on November 11, 2020: member

cc @troygiorshev @jnewbery
DrahtBot removed the label Needs rebase on Nov 11, 2020
jnewbery commented at 8:01 PM on November 11, 2020: member

Concept ACK making protected members private if they don't need to be protected. I'll review once #19673 is merged and this is rebased.
practicalswift commented at 8:43 PM on November 11, 2020: contributor

Concept ACK
DrahtBot commented at 12:02 AM on November 12, 2020: member



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

No conflicts as of last run.
promag commented at 11:14 AM on November 14, 2020: member

Concept ACK.

I'd drop the "consolidate" commit. But if it's kept then it could be marked move-only. Also, there's an unnecessary public:.
sipa commented at 5:09 AM on December 27, 2020: member

utACK 75f7e47b3ae59b7a8b1f5ec86ac281403a50a604
MarcoFalke commented at 8:51 AM on December 27, 2020: member

Tend to NACK for the same reason: #19673#pullrequestreview-557045721
DrahtBot added the label Needs rebase on Jan 2, 2021
jnewbery commented at 9:43 AM on January 6, 2021: member

@hebasto could you rebase now that #20816 is merged?
hebasto force-pushed on Jan 9, 2021
hebasto commented at 9:17 AM on January 9, 2021: member

Updated 75f7e47b3ae59b7a8b1f5ec86ac281403a50a604 -> 7f20edf4bb827a368b8eaf8d2c22643d5935c613 (pr20373.01 -> pr20373.02). @jnewbery

@hebasto could you rebase now that #20816 is merged?

Done. @promag

... if it's kept then it could be marked move-only.

Done.

Also, there's an unnecessary public:.

Fixed.
jnewbery commented at 10:47 AM on January 9, 2021: member

ACK 7f20edf4bb827a368b8eaf8d2c22643d5935c613

Verified that this is move-only, except for making the protected members private.

Thanks for cleaning this up!
DrahtBot removed the label Needs rebase on Jan 9, 2021
DrahtBot added the label Needs rebase on Jan 10, 2021
refactor, move-only: Relocate CNode private members acebb79d3f
refactor, net: Increase CNode data member encapsulation
All protected CNode data members could be private.
3642b2ed34
hebasto force-pushed on Jan 10, 2021
hebasto commented at 10:06 AM on January 10, 2021: member

Updated 7f20edf4bb827a368b8eaf8d2c22643d5935c613 -> 3642b2ed34e6609e8de558b352516daadb12cac1 (pr20373.02 -> pr20373.03) due to the conflict with #20881.
DrahtBot removed the label Needs rebase on Jan 10, 2021
jnewbery commented at 10:40 AM on January 11, 2021: member

utACK 3642b2ed34e6609e8de558b352516daadb12cac1