build: Update univalue subtree #20424

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:2011-subtreeUnivalue changing 2 files +18 −2
  1. MarcoFalke commented at 2:51 PM on November 19, 2020: member

    Just a minor bugfix: Currently we don't push booleans into arrays, but if we did they'd be pushed as integers.

    Can be tested by reverting the diff in include/ and observing a test failure.

  2. Squashed 'src/univalue/' changes from 98261b1e7b..98fadc0909
    98fadc0909 Merge #24: Push bool into array correctly
    5f03f1f39a Push bool into array correctly
    
    git-subtree-dir: src/univalue
    git-subtree-split: 98fadc090984fa7e070b6c41ccb514f69a371c85
    2a55a0ed30
  3. Update univalue subtree fa17eef627
  4. MarcoFalke added this to the milestone 22.0 on Nov 19, 2020
  5. MarcoFalke added the label Build system on Nov 19, 2020
  6. MarcoFalke commented at 2:58 PM on November 19, 2020: member
  7. laanwj commented at 4:22 PM on November 19, 2020: member

    ACK fa17eef6274811be5348149443e563bca95d54a3

    Unfortunately these kind of errors (combined with C++'s automatic type promotion) is one of the pitfalls of using C++ method overloading

  8. practicalswift commented at 9:16 AM on November 20, 2020: contributor

    cr ACK fa17eef6274811be5348149443e563bca95d54a3

    Implicit conversions are the worst! 😢

  9. fanquake merged this on Nov 20, 2020
  10. fanquake closed this on Nov 20, 2020

  11. MarcoFalke deleted the branch on Nov 20, 2020
  12. sidhujag referenced this in commit e514c50946 on Nov 20, 2020
  13. luke-jr commented at 12:10 AM on November 25, 2020: member

    Why isn't this upstreamed?

  14. PastaPastaPasta referenced this in commit 5c692daf17 on Jul 17, 2021
  15. DrahtBot locked this on Feb 15, 2022

Milestone
22.0


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me