Just a minor bugfix: Currently we don't push booleans into arrays, but if we did they'd be pushed as integers.
Can be tested by reverting the diff in include/ and observing a test failure.
Just a minor bugfix: Currently we don't push booleans into arrays, but if we did they'd be pushed as integers.
Can be tested by reverting the diff in include/ and observing a test failure.
98fadc0909 Merge #24: Push bool into array correctly
5f03f1f39a Push bool into array correctly
git-subtree-dir: src/univalue
git-subtree-split: 98fadc090984fa7e070b6c41ccb514f69a371c85
ACK fa17eef6274811be5348149443e563bca95d54a3
Unfortunately these kind of errors (combined with C++'s automatic type promotion) is one of the pitfalls of using C++ method overloading
cr ACK fa17eef6274811be5348149443e563bca95d54a3
Implicit conversions are the worst! 😢
Why isn't this upstreamed?