build: fix determinism issue when building qt with Clang 8 #20440

1. 
   fanquake commented at 1:56 pm on November 21, 2020: member

   Potential alternative to #20436. This is a patch, rather than changes being echo’d into the src/gui/Makefile post configure. It’s also scoped to just darwin. Changes are based off versiontagging_compiler in corelib/global/global.pri.

   From #20436:

   I suspect @fanquake will hate the fact that we’re echoing into a generated file. This would be much cleaner if done at the qmake level

   I guess this is at the qmake level, but still feels like a bit of a hack. If we decide to go this way will add Carl/Cory as co-authors.

2. fanquake added the label Build system on Nov 21, 2020
3. 
   laanwj commented at 2:00 pm on November 21, 2020: member

   Concept ACK
4. 
   DrahtBot commented at 3:01 pm on November 21, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #20447 (depends: Patch qt_intersect_spans to avoid non-deterministic behavior in LLVM 8 by achow101)
   • #19867 (build: document and cleanup Qt hacks by fanquake)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. 
   DrahtBot commented at 7:33 am on November 22, 2020: member

   🐙 This pull request conflicts with the target branch and needs rebase.

   Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

6. DrahtBot added the label Needs rebase on Nov 22, 2020
7. build: fix determinism issue when building qt with Clang 8 9276fe0216
8. fanquake force-pushed on Nov 23, 2020
9. fanquake removed the label Needs rebase on Nov 23, 2020
10. fanquake closed this on Nov 23, 2020

    ---

11. fanquake referenced this in commit 31c9987976 on Nov 24, 2020
12. sidhujag referenced this in commit b5fbf10b7d on Nov 24, 2020
13. fanquake locked this on Feb 22, 2021
14. fanquake deleted the branch on Nov 9, 2022

Contributors
fanquake laanwj DrahtBot

Labels
Build system