test: Add testing of ParseInt/ParseUInt edge cases with leading +/-/0:s #20472

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:parse-int-edge-cases changing 1 files +17 −0

practicalswift commented at 8:44 AM on November 24, 2020: contributor

Add testing of ParseInt/ParseUInt edge cases with leading +/-/0:s.

Context: While working on #20457 and #20452 I noticed some edge cases which our unit tests are currently not covering.
test: Add testing of ParseInt/ParseUInt edge cases with leading +/-/0:s 05c1095388
fanquake added the label Tests on Nov 24, 2020
MarcoFalke commented at 9:16 AM on November 24, 2020: member

review ACK 05c10953887bd78af2e21ef6d3c07f90dd885572

assuming tests pass
laanwj commented at 9:39 AM on November 24, 2020: member

Code review ACK 05c10953887bd78af2e21ef6d3c07f90dd885572
jonatack commented at 10:58 AM on November 24, 2020: member

ACK 05c10953887bd78af2e21ef6d3c07f90dd885572
promag commented at 11:04 AM on November 24, 2020: member

Code review ACK 05c10953887bd78af2e21ef6d3c07f90dd885572.
MarcoFalke merged this on Nov 24, 2020
MarcoFalke closed this on Nov 24, 2020
sidhujag referenced this in commit 3a1441004a on Nov 24, 2020
practicalswift deleted the branch on Apr 10, 2021
PastaPastaPasta referenced this in commit 46a05ad537 on Jun 27, 2021
PastaPastaPasta referenced this in commit f059da98e6 on Jun 28, 2021
PastaPastaPasta referenced this in commit 840d3332e4 on Jun 29, 2021
PastaPastaPasta referenced this in commit 1c80f26441 on Jul 1, 2021
PastaPastaPasta referenced this in commit dea0bfecd1 on Jul 1, 2021
PastaPastaPasta referenced this in commit 1621639e85 on Jul 15, 2021
PastaPastaPasta referenced this in commit 0bb4bb8db0 on Sep 17, 2021
PastaPastaPasta referenced this in commit 4485b3ea20 on Sep 19, 2021
PastaPastaPasta referenced this in commit 40f2d3e692 on Sep 21, 2021
PastaPastaPasta referenced this in commit 2328ead832 on Sep 24, 2021
kittywhiskers referenced this in commit 91f5c0d329 on Oct 12, 2021
deadalnix referenced this in commit 0e5745ce31 on Feb 22, 2022
DrahtBot locked this on Aug 16, 2022

Contributors

Labels

Linked (view graph)

#20452 util: Replace use of locale dependent atoi(…) with locale-independent std::from_chars(…) (C++17)#20457 util: Make Parse{Int,UInt}{32,64} use locale independent std::from_chars(…) (C++17) instead of locale dependent strto{l,ll,ul,ull}