Add depends qt fix for ARM macs

jonasschnelli commented at 8:02 pm on November 24, 2020: contributor

With this, depends builds fine on macOS 11 on an Apple Silicon Mac (ARM64).

Add depends qt fix for ARM macs c23f6f84ef

jonasschnelli added the label macOS on Nov 24, 2020

jonasschnelli commented at 8:03 pm on November 24, 2020: contributor

cross compiling apple arm64 (aarch64-apple-darwin) on a linux host will requires some more work.

luke-jr commented at 8:07 pm on November 24, 2020: member

Concept ACK.

Did you check if various aarch64 assembly bits (libsecp256k1?) work correclty? I seem to recall reading that Apple’s aarch64 isn’t 100% compatible with normal aarch64…

P.S. AIUI, aarch64 is not actually related to the ‘arm’ architecture.

jonasschnelli commented at 8:14 pm on November 24, 2020: contributor

Did you check if various aarch64 assembly bits (libsecp256k1?) work correclty? I seem to recall reading that Apple’s aarch64 isn’t 100% compatible with normal aarch64…

I did a full IBD on an apple ARM64 M1 (not using the Rosetta 2 X86 virtualisation).

P.S. AIUI, aarch64 is not actually related to the ‘arm’ architecture.

AFAIK AArch64 is an optional 64bit architecture implemented by >=ARMv8? But it is confusing anyways.

sipa commented at 9:07 pm on November 24, 2020: member

@luke-jr libsecp256k1 only has 32-bit ARM asm code, and it’s not enabled by default in Bitcoin Core builds.

MarcoFalke added the label Build system on Nov 25, 2020

MarcoFalke added the label GUI on Nov 25, 2020

MarcoFalke added the label Needs gitian build on Nov 25, 2020

MarcoFalke added the label Needs Guix build on Nov 25, 2020

laanwj commented at 8:06 am on November 25, 2020: member

Concept ACK, glad so see that it built with so few changes.

DrahtBot commented at 1:16 pm on November 26, 2020: member

Guix builds

File	commit afdfd3c8c1ce96adae11809e3989de381137fee9(master)	commit 45974345373221aab3f8f6d0efdc173b2843a1e5(master and this pull)
*-aarch64-linux-gnu-debug.tar.gz	`321e361023e8ea7b...`	`a5a04407cb3d74b8...`
*-aarch64-linux-gnu.tar.gz	`b054d1129516836e...`	`fe5fde82b6c7d624...`
*-arm-linux-gnueabihf-debug.tar.gz	`cdd6185a356e7a80...`	`1d27fabdc960b139...`
*-arm-linux-gnueabihf.tar.gz	`4db9b1126b6601b7...`	`208e7f16c3032fe6...`
*-riscv64-linux-gnu-debug.tar.gz	`df4a6eb0267f7140...`	`c26a09f01f343e8b...`
*-riscv64-linux-gnu.tar.gz	`3ff6d83bd5983e2b...`	`1bd23db97e9c4bd1...`
*-win-unsigned.tar.gz	`0dbc83ed5f22a4db...`	`d986246315c80e67...`
*-win64-debug.zip	`539b210aa13b56bc...`	`95e355a36c30810d...`
*-win64-setup-unsigned.exe	`5ff779deff3db721...`	`338d6f58ee18902d...`
*-win64.zip	`4e50c84031e8b116...`	`9f7d2f603bf7fa86...`
*-x86_64-linux-gnu-debug.tar.gz	`345daa571d3557b0...`	`f187c263986f3f02...`
*-x86_64-linux-gnu.tar.gz	`60655c6fb26e8633...`	`86ebd75b08f11060...`
*.tar.gz	`0ddcf17cb856ed92...`	`370f79f93884d76e...`
guix_build.log	`6670400b0a6511d0...`	`06fe186719cd63dc...`
guix_build.log.diff		`3864811e9ad9319a...`

DrahtBot removed the label Needs Guix build on Nov 26, 2020

DrahtBot commented at 3:10 pm on November 26, 2020: member

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

DrahtBot commented at 1:04 pm on November 29, 2020: member

Gitian builds

File	commit e2ff5e7b35d71195278d2a2ed9485f141de33d7a(master)	commit bc5f2b9ee971a2d4a7468c63e07b82deca93a175(master and this pull)
bitcoin-core-linux-22-res.yml	`44e52af36236879f...`	`b5895d49e61d0ac9...`
bitcoin-core-osx-22-res.yml	`71d5fb0e6642d6b0...`	`6a1679fa67603bff...`
bitcoin-core-win-22-res.yml	`0148a2f5e7295184...`	`20f9506be98c3c65...`
*-aarch64-linux-gnu-debug.tar.gz	`383e84aaa96f342a...`	`7dcc4170bca617bc...`
*-aarch64-linux-gnu.tar.gz	`3558211891c0484a...`	`fbd5ec07ec47c0bf...`
*-arm-linux-gnueabihf-debug.tar.gz	`5ebbb475a590480a...`	`230472cd7c4b0c84...`
*-arm-linux-gnueabihf.tar.gz	`60951d893e2688b6...`	`50b9c33b2b68d4a8...`
*-osx-unsigned.dmg	`7cba6edda598c96c...`	`67f2ccede9f96831...`
*-osx64.tar.gz	`ea2ab5c893780a2e...`	`bdf45bf6ae475f67...`
*-riscv64-linux-gnu-debug.tar.gz	`0c20a43923efcd5f...`	`59b3486072dd3a53...`
*-riscv64-linux-gnu.tar.gz	`8d3632d81c77eff1...`	`5c821fb948099519...`
*-win64-debug.zip	`72c35e133cf9a0db...`	`5c5fe4a050f37923...`
*-win64-setup-unsigned.exe	`55c17bfff54273e5...`	`55d659d6b5d14dda...`
*-win64.zip	`f7bf6737c7f741c3...`	`f7def119620dc76c...`
*-x86_64-linux-gnu-debug.tar.gz	`abf91baef5c44686...`	`9f4b7946dc3a3c1a...`
*-x86_64-linux-gnu.tar.gz	`75fda490174df335...`	`6152ecfb5058a1f9...`
*.tar.gz	`793a2c7af39452d5...`	`b1ac4913e6c09436...`
linux-build.log	`9c5461a914e1f4c0...`	`393a3922a89086ab...`
osx-build.log	`5adaf67afbaf00fc...`	`448032ad16eccc03...`
win-build.log	`756101ecccffabf0...`	`eb2188fda5c43a83...`
bitcoin-core-linux-22-res.yml.diff		`9c0bbf79417d5979...`
bitcoin-core-osx-22-res.yml.diff		`793b672afa2c7dfb...`
bitcoin-core-win-22-res.yml.diff		`609abc0827da46fc...`
linux-build.log.diff		`18255436264ba93e...`
osx-build.log.diff		`7fb8f7eff038c67f...`
win-build.log.diff		`345b25722c8b48ac...`

DrahtBot removed the label Needs gitian build on Nov 29, 2020

fanquake commented at 8:57 am on November 30, 2020: member

Concept ACK - no hardware to test this on though.

laanwj commented at 12:07 pm on December 3, 2020: member

Looks like this upstream bug is not solved in any releases. So it won’t just go away with a more recent Qt (at least not one we’re going to upgrade to before 0.22).

laanwj commented at 9:06 am on December 7, 2020: member

Code review ACK c23f6f84efa2fe7e7168a5d41341f3a7c5598f70

laanwj merged this on Dec 7, 2020

laanwj closed this on Dec 7, 2020

sidhujag referenced this in commit 84408c758f on Dec 7, 2020

PastaPastaPasta referenced this in commit 727296f3c5 on Jun 27, 2021

PastaPastaPasta referenced this in commit 3cc149a481 on Jun 28, 2021

PastaPastaPasta referenced this in commit 619d098cbe on Jun 29, 2021

PastaPastaPasta referenced this in commit 5d1c3beaed on Jul 1, 2021

PastaPastaPasta referenced this in commit 01b4ac5927 on Jul 1, 2021

PastaPastaPasta referenced this in commit 993a6a1713 on Jul 15, 2021

PastaPastaPasta referenced this in commit 9ff3643bfa on Jul 16, 2021

DrahtBot locked this on Feb 15, 2022

Add depends qt fix for ARM macs #20482

Guix builds

Conflicts

Gitian builds