refactor: Move node and wallet code out of src/interfaces

ryanofsky commented at 2:39 pm on November 25, 2020: member

This PR is part of the process separation project.

Move NodeImpl from interfaces/node.cpp to node/interfaces.cpp Move ChainImpl from interfaces/chain.cpp to node/interfaces.cpp Move WalletImpl from interfaces/wallet.cpp to wallet/interfaces.cpp

No changes to any classes (can review with git diff --color-moved=dimmed_zebra)

Motivation for this change is to move node and wallet code to respective directories where it might fit in better than src/interfaces/, but also to remove all unnecessary code from src/interfaces/ to unblock #19160 review, which has been hung up partially because of code organization. Building on top of this PR, #19160 should now be able to organize interface implementations more understandably in src/node/ src/wallet/ src/ipc/ and src/init/ directories instead of having so much functionality all in src/interfaces/

Move NodeImpl from interfaces/node.cpp to node/interfaces.cpp 12bd0fc9d7

Move ChainImpl from interfaces/chain.cpp to node/interfaces.cpp

No changes to ChainImpl or any related classes (review with `git diff --color-moved=dimmed_zebra`)

2a26771d81

Move WalletImpl from interfaces/wallet.cpp to wallet/interfaces.cpp 629a9299b2

fanquake added the label Refactoring on Nov 25, 2020

ryanofsky added this to the "In progress" column in a project

DrahtBot commented at 3:42 pm on November 25, 2020: member

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#20530 (lint, refactor: Update cppcheck linter to c++17 and improve explicit usage by fjahr)
#20172 (rpc, net: Expose connections_onion_only in getnetworkinfo RPC output by hebasto)
#19910 (net processing: Move peer_map to PeerManager by jnewbery)
#19901 (Avoid locking CTxMemPool::cs recursively in CTxMemPool::DynamicMemoryUsage() by hebasto)
#19771 (net: Replace enum CConnMan::NumConnections with enum class ConnectionDirection by luke-jr)
#18766 (Disable fee estimation in blocksonly mode (by removing the fee estimates global) by darosior)
#17167 (Allow whitelisting outgoing connections by luke-jr)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

promag commented at 0:02 am on November 30, 2020: member

Code review ACK 629a9299b2a7241a3fa7d597cb34abcbe1af9255.

This change is reasonable, interface implementations are moved to their “home”.

in src/node/interfaces.cpp:7 in 2a26771d81 outdated

1@@ -2,47 +2,58 @@
2 // Distributed under the MIT software license, see the accompanying
3 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
4 
5-#include <interfaces/node.h>
6-
7 #include <addrdb.h>
8 #include <banman.h>
9+#include <boost/signals2/signal.hpp>

MarcoFalke commented at 8:35 am on December 1, 2020:

why is this moved?

ryanofsky commented at 2:23 pm on December 1, 2020:

re: #20494 (review)

why is this moved?

Not sure. This came from #19160 where I was using IWYU a lot. I tried to manually sort system includes below project includes after running it, but I wasn’t very diligent. It’d be more convenient if there was just a single include section, or an automatic include sorter

MarcoFalke approved

MarcoFalke commented at 8:39 am on December 1, 2020: member

review ACK 629a9299b2a7241a3fa7d597cb34abcbe1af9255 🔺

Signature:

 0-----BEGIN PGP SIGNED MESSAGE-----
 1Hash: SHA512
 2
 3review ACK 629a9299b2a7241a3fa7d597cb34abcbe1af9255 🔺
 4-----BEGIN PGP SIGNATURE-----
 5
 6iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
 7pUgpKgv9FXDr3pKOUjSzUhQP8v6tY0NTOf/V0UP6izQZuoOkAxjFJq/FgXNAgnU7
 8NyX7VHnqx/1gf+GAOpKrcxvWderBde6fDPNHS+jcZo4aNsv15Vsqv/Fia9VaKw0h
 9kBkEzWm8N3hEktVdqTsZrGee26qD0jlJM64eW/Se9Kq3D6uQgyusEOJ5uiu6cmG4
10ycXeRnTCs1PCneNlt/6hypLs9iSe5RUHhM8rmEFh6HLBmW0t+mpca7cOdGmZAGXp
11R+rMTh8LeljiEL10I/v1pg0OYDOIJ7IQpERwrajiB4eWVgHbHmxqr1AVGikQDm36
12StCw6QRCV0GzRPE963zpP5SvI0JxdOTTrTBzlKZqCMO5b1hoZJDq/9NEUIZQWIVq
134nYDDtyrQBqSunNAqEi1QAmEbt+IhGZR4v0yWGZHLLOuAXOAs+X5GbOwRzgPQeAC
14rx9EawhmAxgH1tkSUScC3xyYgeN5GGosF9yX8xrocoQNKbILu1E8y1u1tt1Izjkx
15SAS0x21D
16=i4RY
17-----END PGP SIGNATURE-----

Timestamp of file with hash bfed3f19ad97ec6b521680bc88144a3f4a28fae8cda34c721b3183fddf8c449c -

MarcoFalke merged this on Dec 1, 2020

MarcoFalke closed this on Dec 1, 2020

sidhujag referenced this in commit ac0b2e1a3f on Dec 1, 2020

ryanofsky moved this from the "In progress" to the "Done" column in a project

DrahtBot locked this on Feb 15, 2022

refactor: Move node and wallet code out of src/interfaces #20494

Conflicts