[backport] wallet: allow zero-fee fundrawtransaction/walletcreatefundedpsbt and other fixes #20510

1. 
   jonatack commented at 4:45 pm on November 26, 2020: member

   Github-Pull: #20426 Rebased-From: 1b3d7009280595108eb22ac1188bc4367804fc5d

   Github-Pull: #20426 Rebased-From: 3f1e10b2b1cd11f7112fbad6355464bd4adbbc5c

   Github-Pull: #20426 Rebased-From: 9f08780dd7946b63476e9736745131db8e7f4e93

2. fanquake added the label Backport on Nov 26, 2020
3. 
   fanquake commented at 5:22 pm on November 26, 2020: member

   The GitHub-Pull & Rebased-From metadata should be included with each commit.
4. 
   jonatack commented at 6:18 pm on November 26, 2020: member

   I just realized there’s bitcoin-maintainer-tools/backport.py, will give it a try.
5. Allow zero-fee fundrawtxn and walletcreatefundedpsbt calls

   A check to raise an error on zero-fee txns was mistakenly extended in commit
   a0d4957 from the bumpfee and send{toaddress, many} RPCs to also include
   fundrawtransaction and walletcreatefundedpsbt.
   
   This commit overrides zero fee rate checking for these two RPCs, not only for
   the feeRate (BTC/kvB) arg to return to previous behavior, but also for the new
   fee_rate (sat/vB) arg.
   
   Github-Pull: #20426
   Rebased-From: 1b3d7009280595108eb22ac1188bc43678

   54e1edcc2b
6. Update feeRate (BTC/kvB) to fee_rate (sat/vB) in wallet_bumpfee

   as the feeRate argument should soon be deprecated.
   
   Also loosen one test (and a similar one) that caused a one-off CI failure with:
   expected message
   'Insufficient total fee 0.00000141, must be at least 0.00001704 (oldFee 0.00000999 + incrementalFee 0.00000705)'
   actual message
   'Insufficient total fee 0.00000141, must be at least 0.00001712 (oldFee 0.00001007 + incrementalFee 0.00000705)'
   
   Github-Pull: #20426
   Rebased-From: 3f1e10b2b1cd11f7112fbad6355464bd4adbbc5c

   6e4969f76f
7. Use the correct incremental fee constant in bumpfee help

   and remove redundant units ("Must be at least 1.000 sat/vB sat/vB" -> "1.00 sat vB")
   
   Github-Pull: #20426
   Rebased-From: 9f08780dd7946b63476e9736745131db8e7f4e93

   6313362553
8. jonatack force-pushed on Nov 26, 2020
9. 
   jonatack commented at 6:35 pm on November 26, 2020: member

   Thanks @fanquake, done.
10. 
    MarcoFalke commented at 7:57 pm on November 26, 2020: member

    #20490 didn’t need cherry-picks, so I opted to merge without rebase. Though when cherry-picks are needed, it is better to include where they were cherry-picked from.
11. 
    jonatack commented at 8:34 pm on November 26, 2020: member

    Thanks @MarcoFalke.
12. MarcoFalke added this to the milestone 0.21.0 on Dec 4, 2020
13. MarcoFalke merged this on Dec 4, 2020
14. MarcoFalke closed this on Dec 4, 2020

    ---

15. DrahtBot locked this on Feb 15, 2022

Contributors
jonatack fanquake MarcoFalke

Labels
Backport

Milestone
0.21.0