Handle rename failure in DumpMempool(...) by using the RenameOver(...) return value.
Add [[nodiscard]] to RenameOver(...) to reduce the risk of similar rename issues in the future.
Handle rename failure in DumpMempool(...) by using the RenameOver(...) return value. Add [[nodiscard]] to RenameOver(...). #20519
pull practicalswift wants to merge 2 commits into bitcoin:master from practicalswift:renameover-nodiscard changing 2 files +4 −2-
practicalswift commented at 12:48 PM on November 27, 2020: contributor
-
Handle rename failure in DumpMempool(...) by using RenameOver(...) return value 9429a398e2
-
Add [[nodiscard]] to RenameOver(...) ce9dd45422
- vasild approved
-
vasild commented at 1:09 PM on November 27, 2020: member
ACK ce9dd454
This was the only place where the return value of
RenameOver()was not inspected.Would be useful to print the reason for the rename failure, but that's out of the scope of this PR.
- DrahtBot added the label Utils/log/libs on Nov 27, 2020
- DrahtBot added the label Validation on Nov 27, 2020
- theStack approved
-
theStack commented at 4:17 PM on November 29, 2020: member
ACK ce9dd45422e1f4ecce6df68da086b8bfc2100756 🏷️
- luke-jr approved
-
luke-jr commented at 6:07 PM on November 30, 2020: member
utACK
- MarcoFalke merged this on Dec 1, 2020
- MarcoFalke closed this on Dec 1, 2020
- sidhujag referenced this in commit 161efc874a on Dec 1, 2020
- practicalswift deleted the branch on Apr 10, 2021
- PastaPastaPasta referenced this in commit f8fa18037f on Jun 27, 2021
- PastaPastaPasta referenced this in commit 7a09b5d635 on Jun 28, 2021
- PastaPastaPasta referenced this in commit d6e7776f25 on Jun 29, 2021
- PastaPastaPasta referenced this in commit c548bdd5f3 on Jul 1, 2021
- PastaPastaPasta referenced this in commit fc54ece0a1 on Jul 1, 2021
- PastaPastaPasta referenced this in commit aa566e5d88 on Jul 15, 2021
- PastaPastaPasta referenced this in commit 7920dce8bc on Jul 15, 2021
- PastaPastaPasta referenced this in commit 5bda1b9398 on Sep 17, 2021
- PastaPastaPasta referenced this in commit d8a9d791e5 on Sep 19, 2021
- PastaPastaPasta referenced this in commit 1d8363e741 on Sep 21, 2021
- PastaPastaPasta referenced this in commit 4d8f035207 on Sep 24, 2021
- kittywhiskers referenced this in commit 78b174a666 on Oct 12, 2021
- Fabcien referenced this in commit 7bb25596e5 on Jan 26, 2022
- gades referenced this in commit aa651536ef on Apr 19, 2022
- DrahtBot locked this on Aug 16, 2022
Contributors
Labels