Support make src/bitcoin-node and src/bitcoin-gui #20549

pull promag wants to merge 1 commits into bitcoin:master from promag:2020-12-make-bitcoin-node changing 2 files +13 −0
  1. promag commented at 5:48 PM on December 2, 2020: member

    This change adds the following configure output variables

    dnl Multi Process
    BITCOIN_MP_NODE_NAME=bitcoin-node
    BITCOIN_MP_GUI_NAME=bitcoin-gui
    

    and adds support for

    make src/bitcoin-node src/bitcoin-gui
    
  2. ryanofsky approved
  3. ryanofsky commented at 6:07 PM on December 2, 2020: member

    Code review ACK e491f754ce23c18af06f19ab168a5981d308f021. Seems reasonable. I didn't know about these shortcuts or I would have included this in #18677

  4. promag commented at 6:12 PM on December 2, 2020: member

    @ryanofsky right, I was reviewing #19160 but didn't want to add this noise there. Maybe I should add bitcoin-gui too? others?

  5. ryanofsky commented at 6:49 PM on December 2, 2020: member

    @ryanofsky right, I was reviewing #19160 but didn't want to add this noise there. Maybe I should add bitcoin-gui too? others?

    Sure, more consistency is more better

  6. DrahtBot added the label Build system on Dec 2, 2020
  7. promag force-pushed on Dec 2, 2020
  8. promag renamed this:
    Support make src/bitcoin-node
    Support make src/bitcoin-node and src/bitcoin-gui
    on Dec 2, 2020
  9. Support make src/bitcoin-node and src/bitcoin-gui 206f74e88c
  10. promag force-pushed on Dec 2, 2020
  11. promag commented at 11:08 PM on December 2, 2020: member

    @ryanofsky updated, added bitcoin-gui.

  12. DrahtBot commented at 2:44 AM on December 3, 2020: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #19937 (signet mining utility by ajtowns)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  13. luke-jr approved
  14. luke-jr commented at 4:54 PM on December 6, 2020: member

    utACK

  15. laanwj commented at 11:53 AM on December 10, 2020: member

    Code review ACK 206f74e88cfa343d228c1d6596d3846863824ca5

  16. laanwj merged this on Dec 10, 2020
  17. laanwj closed this on Dec 10, 2020

  18. promag deleted the branch on Dec 10, 2020
  19. sidhujag referenced this in commit d34c7e1e9b on Dec 10, 2020
  20. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 00:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me