test: Fix intermittent wallet_multiwallet issue with got_loading_error #20569

1. 
   MarcoFalke commented at 9:30 AM on December 4, 2020: member

   Failing the test after 10 iterations without a loading error is problematic because it may take 11 iterations to get a loading error.

   Fix that by running until a loading error occurs, which should happen in almost all runs within the first 10 iterations.

2. test: pep8 wallet_multiwallet.py fa8e15f7b7
3. 
   MarcoFalke commented at 9:30 AM on December 4, 2020: member

   https://cirrus-ci.com/task/5005908700823552?command=ci#L5178

4. fanquake added the label Tests on Dec 4, 2020
5. test: Fix intermittent wallet_multiwallet issue with got_loading_error fab48da908
6. MarcoFalke force-pushed on Dec 4, 2020
7. MarcoFalke requested review from ryanofsky on Dec 16, 2020
8. MarcoFalke requested review from promag on Dec 16, 2020
9. ryanofsky approved
10. 
    ryanofsky commented at 2:41 PM on December 16, 2020: member

    Code review ACK fab48da908f3f81135b9163edf5011d1e5f6ef6e. This seems like a good workaround. I think more ideally think load and unload RPCs would not have racy status reporting (suggested previously #19300#pullrequestreview-435362710 and #19232 (comment)) so the race condition that this test tries to trigger just wouldn't exist.

    Also for reference there was discussion about fragility of this test when it was added #19300 (review)

11. MarcoFalke merged this on Dec 16, 2020
12. MarcoFalke closed this on Dec 16, 2020

    ---

13. MarcoFalke deleted the branch on Dec 16, 2020
14. sidhujag referenced this in commit fa317ee7d0 on Dec 17, 2020
15. 
    PiRK commented at 3:24 PM on December 15, 2021: contributor

    Doesn't that introduce a risk that one of the 3 threads never detects a race and keeps running forever alone without interference from the other two?

16. 
    PiRK commented at 8:50 AM on December 20, 2021: contributor

    nvm, I missed the fact that got_loading_error is a global.

17. Fabcien referenced this in commit 56d69f8c37 on Dec 20, 2021
18. DrahtBot locked this on Dec 20, 2022

Review Requested
promag