[doc] Tidy up Tor doc (more stringent) #20587

pull ghost wants to merge 1 commits into bitcoin:master from changing 1 files +3 −4

ghost commented at 4:20 AM on December 7, 2020: none

This is a follow up to #19638 that left two deprecated "hidden service/server" naming occurences.

It also shall make the chapter titles regarding creation of onion services stringent and easy to read and distinguish.

It removes the one and only reference to the testnet (here the testnet onion service port), as it is not explained that it references to the testnet and I do not know why it is mentioned there. It is only confusing. Also, as said, the testnet is not referenced at any other place in this document.

[doc] Tidy up Tor doc (more stringent)

This is a follow up to https://github.com/bitcoin/bitcoin/pull/19638 that left some deprectaed "hidden service/server" naming occurences.

It also shall make the chapter titles regarding creation of onion services stringent and easy to read and distinguish.

It removes the one and only reference to the testnet (here the testnet onion service port), as it is not explained that it references to the testnet and I do not know why it is mentioned there. It is only confusing. Also, as said, the testnet is not referenced at any other place in this document.

32045bbfd5

DrahtBot added the label Docs on Dec 7, 2020
DrahtBot commented at 4:09 PM on December 9, 2020: member



🕵️ @harding has been requested to review this pull request as specified in the REVIEWERS file.
practicalswift commented at 9:58 AM on December 10, 2020: contributor

ACK 32045bbfd5d77513efc162be8d4e24ea67539e27

Weird that we were suggesting that users should open up port 18334 (in addition to 8334). Glad to see that addressed :)
RiccardoMasutti approved
RiccardoMasutti commented at 12:57 PM on December 10, 2020: contributor

ACK 32045bb

Thanks, it was an oversight
laanwj commented at 1:40 PM on December 10, 2020: member

Review ACK 32045bbfd5d77513efc162be8d4e24ea67539e27 CI failure is unrelated.

in doc/tor.md:49 in 32045bbfd5

  45 | @@ -46,7 +46,6 @@ versions of Tor see [Section 3](#3-automatically-listen-on-tor).*
  46 |  
  47 |  	HiddenServiceDir /var/lib/tor/bitcoin-service/
  48 |  	HiddenServicePort 8333 127.0.0.1:8334
  49 | -	HiddenServicePort 18333 127.0.0.1:18334

laanwj commented at 1:44 PM on December 10, 2020:

Agree re: testnet. if people want to run Tor testnet (or signet) nodes, they tend to be developers who know how to change around the ports here. It's just confusing as it is.

laanwj merged this on Dec 10, 2020
laanwj closed this on Dec 10, 2020
ghost commented at 3:20 PM on December 10, 2020: none

Thanks for reviewing, glad I could contribute for the better! :tada:
unknown deleted the branch on Dec 10, 2020
sidhujag referenced this in commit b4380c00d3 on Dec 10, 2020
Fabcien referenced this in commit bb0557c2cc on Feb 15, 2022
DrahtBot locked this on Aug 16, 2022

Contributors

Labels

Linked (view graph)

#19638 Replace `hidden service` with `onion service`