doc: update wtxidrelay documentation per BIP339 #20592

pull jonatack wants to merge 1 commits into bitcoin:master from jonatack:update-wtxid-documentation-per-BIP339 changing 1 files +2 −2
  1. jonatack commented at 6:30 pm on December 7, 2020: member

    BIP339 currently states:

    The wtxidrelay message MUST be sent in response to a version message from a peer whose protocol version is >= 70016 and prior to sending a verack. A wtxidrelay message received after a verack message MUST be ignored or treated as invalid.

  2. Update net_processing WTXID documentation per BIP339
    as BIP339 currently states:
    
    "The wtxidrelay message MUST be sent in response to a version
    message from a peer whose protocol version is >= 70016 and
    prior to sending a verack. A wtxidrelay message received after
    a verack message MUST be ignored or treated as invalid."
    4b7b58b3fe
  3. MarcoFalke added the label Docs on Dec 7, 2020
  4. MarcoFalke commented at 6:43 pm on December 7, 2020: member

    ACK 4b7b58b3fef5b9566a475871c441ed6ae73af89e

    Though, let’s wait on merging this to make sure this doesn’t cause any conflicts with pending backports

  5. MarcoFalke renamed this:
    p2p: update wtxidrelay documentation per BIP339
    doc: update wtxidrelay documentation per BIP339
    on Dec 7, 2020
  6. practicalswift commented at 6:30 am on December 8, 2020: contributor
    ACK 4b7b58b3fef5b9566a475871c441ed6ae73af89e
  7. DrahtBot commented at 7:38 pm on December 8, 2020: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #20599 (net processing: Tolerate sendheaders and sendcmpct messages before verack by jnewbery)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  8. DrahtBot commented at 4:09 pm on December 9, 2020: member

    🕵️ @sipa has been requested to review this pull request as specified in the REVIEWERS file.

  9. RiccardoMasutti changes_requested
  10. RiccardoMasutti commented at 12:56 pm on December 10, 2020: contributor
    ACK 4b7b58b
  11. luke-jr approved
  12. luke-jr commented at 2:19 am on December 14, 2020: member
    ACK
  13. MarcoFalke merged this on Dec 14, 2020
  14. MarcoFalke closed this on Dec 14, 2020

  15. sidhujag referenced this in commit 17d69b90e5 on Dec 14, 2020
  16. jonatack deleted the branch on Dec 14, 2020
  17. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me