configure: output notice that test binary is disabled by fuzzing #20609

pull apoelstra wants to merge 1 commits into bitcoin:master from apoelstra:2020-12--fuzz-config-output changing 1 files +9 −3

apoelstra commented at 11:36 PM on December 9, 2020: contributor

I wasted a bit of time today running a stale test_bitcoin and not understanding why, until I remembered that I'd ./configured my working directory with --enable-fuzz.
fanquake added the label Build system on Dec 9, 2020

in configure.ac:1589 in 3e5662a8b9 outdated

1584 | @@ -1585,7 +1585,11 @@ AM_CONDITIONAL([ENABLE_ZMQ], [test "x$use_zmq" = "xyes"])
1585 |  
1586 |  AC_MSG_CHECKING([whether to build test_bitcoin])
1587 |  if test x$use_tests = xyes; then
1588 | -  AC_MSG_RESULT([yes])
1589 | +  if test "x$enable_fuzz" = "xyes"; then
1590 | +    AC_MSG_RESULT([no, becasue fuzzing is enabled])

practicalswift commented at 11:42 PM on December 9, 2020:

I read "barbecue" here 🥩

apoelstra commented at 11:46 PM on December 9, 2020:

lol! I checked the output with all four test/fuzz combinations and failed to see the typo every time.

practicalswift commented at 11:44 PM on December 9, 2020: contributor

Concept ACK

Welcome back as a code contributor to this repo @apoelstra! :)
configure: output notice that test binary is disabled by fuzzing 904d875cf5
apoelstra force-pushed on Dec 9, 2020
laanwj commented at 11:58 PM on December 9, 2020: member

Concept ACK. It's surprising that enabling fuzzers automatically disables other things, probably a good thing to warn.
jonatack commented at 12:16 AM on December 10, 2020: member

Concept ACK, good idea.
DrahtBot commented at 2:25 AM on December 10, 2020: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #16546 (External signer support - Wallet Box edition by Sjors)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

MarcoFalke commented at 8:07 AM on December 10, 2020: member

Rendered diff with enable fuzz:

@@ -286,7 +286,7 @@ checking whether to build libraries... no
 checking if ccache should be used... yes
 checking if wallet should be enabled... no
 checking whether to build with support for UPnP... no
-checking whether to build test_bitcoin... yes
+checking whether to build test_bitcoin... no, because fuzzing is enabled
 checking whether to reduce exports... no
 checking that generated files are newer than configure... done
 configure: creating ./config.status
@@ -548,7 +548,7 @@ Options used to compile and link:
   with wallet   = no
   with gui / qt = no
   with zmq      = no
-  with test     = yes
+  with test     = not building test_bitcoin because fuzzing is enabled
     with fuzz   = yes
   with bench    = no
   with upnp     = no

Rendered diff without fuzz:

@@ -331,7 +331,6 @@ config.status: creating share/qt/Info.plist
 config.status: creating test/config.ini
 config.status: creating contrib/devtools/split-debug.sh
 config.status: creating src/config/bitcoin-config.h
-config.status: src/config/bitcoin-config.h is unchanged
 config.status: executing depfiles commands
 config.status: executing libtool commands
 === configuring in src/univalue (/home/marco/workspace/btc_bitcoin_core/src/univalue)
@@ -586,7 +585,6 @@ Options used to compile and link:
     with qr     = yes
   with zmq      = yes
   with test     = yes
-    with fuzz   = no
   with bench    = yes
   with upnp     = no
   use asm       = yes

MarcoFalke merged this on Dec 10, 2020
MarcoFalke closed this on Dec 10, 2020
sidhujag referenced this in commit 51d75e23fc on Dec 10, 2020
apoelstra deleted the branch on Dec 10, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

configure: output notice that test binary is disabled by fuzzing #20609

Conflicts