The comment was previously attached to m_addr_known, but now it is attached to id, which is wrong.
Fix that by moving the comment to RelayAddrsWithConn.
doc: Move addr relay comment in net to correct place #20653
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2012-docNetAddrRelay changing 2 files +12 −12-
MarcoFalke commented at 5:18 PM on December 14, 2020: member
-
fa86217e97
doc: Move add relay comment in net to correct place
Can be reviewed with --ignore-all-space --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space
- MarcoFalke added the label Docs on Dec 14, 2020
- MarcoFalke added the label P2P on Dec 14, 2020
- MarcoFalke renamed this:
doc: Move add relay comment in net to correct place
doc: Move addr relay comment in net to correct place
on Dec 14, 2020 -
practicalswift commented at 7:44 PM on December 14, 2020: contributor
cr ACK fa86217e97234aac6f815a6768afc1b87b8b2ae8: patch looks correct
-
DrahtBot commented at 8:05 PM on December 14, 2020: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #20649 (refactor: Remove nMyStartingHeight from CNode/Connman by MarcoFalke)
- #20210 (net: ensure CNode::m_inbound_onion is inbound, add getter, unit tests by jonatack)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- theStack approved
-
theStack commented at 9:38 PM on December 14, 2020: member
Code review ACK fa86217e97234aac6f815a6768afc1b87b8b2ae8 🌳 The comment was first introduced in 430f489027f15c1e4948ea4378954df24e3fee88 (#15759)
-
jnewbery commented at 4:39 PM on December 15, 2020: member
ACK fa86217e97
- MarcoFalke merged this on Dec 15, 2020
- MarcoFalke closed this on Dec 15, 2020
- MarcoFalke deleted the branch on Dec 15, 2020
- sidhujag referenced this in commit 73154f0822 on Dec 15, 2020
- DrahtBot locked this on Feb 15, 2022
Contributors