This uses the CNode::ConnectionTypeAsString() strings in place of the all-caps enums in a couple of comments in net_processing, as suggested by ajtowns in #19858 (review).
doc: Remove shouty enums in net_processing comments #20677
pull sdaftuar wants to merge 1 commits into bitcoin:master from sdaftuar:2020-12-remove-shouty-enums changing 1 files +6 −6-
sdaftuar commented at 10:14 PM on December 16, 2020: member
-
doc: Remove shouty enums in net_processing comments 0c41c10830
- fanquake added the label Docs on Dec 16, 2020
-
DrahtBot commented at 1:42 AM on December 17, 2020: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #19843 (Refactoring and minor improvement for self-advertisements by naumenkogs)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- fanquake requested review from ajtowns on Dec 17, 2020
- fanquake requested review from amitiuttarwar on Dec 17, 2020
-
practicalswift commented at 6:57 AM on December 17, 2020: contributor
ACK 0c41c1083089efb158de828f97eb00e206f2869a
-
jnewbery commented at 10:39 AM on December 17, 2020: member
ACK 0c41c1083089efb158de828f97eb00e206f2869a
-
laanwj commented at 10:58 AM on December 17, 2020: member
Yes, why not, this looks better in the text flow; on the other hand using the enum values can allow cross-referencing to the definition of the enum, but i think this would require additional doxygen magic anyway.
ACK 0c41c1083089efb158de828f97eb00e206f2869a
- laanwj merged this on Dec 17, 2020
- laanwj closed this on Dec 17, 2020
- sidhujag referenced this in commit b735ccdf5a on Dec 17, 2020
- DrahtBot locked this on Feb 15, 2022
