ci: Install missing lint packages #20682

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2012-testDel changing 3 files +15 −8
  1. MarcoFalke commented at 11:03 am on December 17, 2020: member
    The cirrus container is vanilla ubuntu, so we need to install the needed packages
  2. fanquake added the label Tests on Dec 17, 2020
  3. MarcoFalke force-pushed on Dec 17, 2020
  4. in .cirrus.yml:74 in fa63121808 outdated 
    78-    - set -o errexit; source ./ci/lint/04_install.sh
79-  before_script:
80-    - set -o errexit; source ./ci/lint/05_before_script.sh
81   lint_script:
82-    - set -o errexit; source ./ci/lint/06_script.sh
83+    - ./ci/lint_run_all.sh
    hebasto commented at 7:48 pm on December 17, 2020:

    I understand that it follows the way how we use the ./ci/test_run_all.sh script, but it seems more readable and maintainable to do not introduce a second-level script:

    0  lint_script: |
1    set -o errexit
2    source ./ci/test/00_setup_env.sh
3    source ./ci/test/03_before_install.sh
4    source ./ci/lint/04_install.sh
5    source ./ci/lint/05_before_script.sh
6    source ./ci/lint/06_script.sh
    MarcoFalke commented at 8:42 pm on December 17, 2020:
    The script makes it also easier to run locally with just one command
  5. in ci/lint/04_install.sh:9 in fa63121808 outdated 
     5@@ -6,7 +6,7 @@
 6 
 7 export LC_ALL=C
 8 
 9-${CI_RETRY_EXE} apt update && apt install -y clang-format-9 python3-pip curl git
10+${CI_RETRY_EXE} apt update && apt install -y clang-format-9 python3-pip curl git gawk jq curl wget
    hebasto commented at 7:52 pm on December 17, 2020: 
    0${CI_RETRY_EXE} apt-get update
1${CI_RETRY_EXE} apt-get install -y clang-format-9 python3-pip curl git gawk jq
  6. hebasto commented at 7:55 pm on December 17, 2020: member

    Concept ACK fa631218084f27df3ff379dceb3dcd3ecaf3d4cc

    Sorry, but I don’t see any reason in the recent push.

    Also I’d suggest to separate COMMIT_RANGE related changes into their own commit, or–better–into a separated PR.

  7. MarcoFalke commented at 8:43 pm on December 17, 2020: member

    Sorry, but I don’t see any reason in the recent push.

    curl is used by the linters

  8. hebasto commented at 11:01 pm on December 17, 2020: member

    Sorry, but I don’t see any reason in the recent push.

    curl is used by the linters

    curl is already in apt install -y clang-format-9 python3-pip curl git :)

    And wget is not used by the linters:

    0$ git grep -e 'wget' test/lint/ | wc -l
10
  9. ci: Install missing lint packages 
    Also merge script into ci/lint_run_all.sh because env vars weren't
exported properly
    faeb40bee3
  10. MarcoFalke force-pushed on Dec 18, 2020
  11. DrahtBot commented at 6:42 am on December 18, 2020: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #20691 (ci, doc: Travis CI features and mentions cleanup by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  12. MarcoFalke commented at 6:42 am on December 18, 2020: member

    Also I’d suggest to separate COMMIT_RANGE related changes into their own commit, or–better–into a separated PR.

    Dropped here

  13. hebasto approved
  14. hebasto commented at 8:11 am on December 18, 2020: member
    ACK faeb40bee3bca9477785659d89af53cafa2333b5, I have reviewed the code and it looks OK, I agree it can be merged.
  15. MarcoFalke merged this on Dec 18, 2020
  16. MarcoFalke closed this on Dec 18, 2020
  17. MarcoFalke deleted the branch on Dec 18, 2020
  18. sheffine commented at 11:41 am on December 18, 2020: none

    Good morning, I am one of bitpay customer and I would like to know which file holds all my tokens that was sent through bitcore and how to o sent it to my wallet. I have been trying to get it done but having a difficult time. Thanks for your help.

    On Thu, Dec 17, 2020 at 6:06 AM MarcoFalke notifications@github.com wrote:

    The cirrus container is vanilla ubuntu, so we need to install the needed packages

    You can view, comment on, or merge this pull request online at:

    #20682 Commit Summary

    • ci: Install missing lint packages

    File Changes

    Patch Links:

    — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/20682, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ3ZHMNYM6TQHWM7FF3I7NLSVHQZTANCNFSM4U7OWW3A .

  19. hebasto commented at 12:20 pm on December 18, 2020: member

    Also I’d suggest to separate COMMIT_RANGE related changes into their own commit, or–better–into a separated PR.

    Dropped here

    Mind looking into #20697 ?

  20. sidhujag referenced this in commit 808573c40e on Dec 18, 2020
  21. MarcoFalke referenced this in commit f061da2887 on Dec 21, 2020
  22. sidhujag referenced this in commit 885721f23e on Dec 21, 2020
  23. DrahtBot locked this on Aug 16, 2022


MarcoFalke hebasto DrahtBot sheffine

Labels
Tests

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 00:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me