ci, doc: Travis CI features and mentions cleanup #20691

hebasto commented at 8:06 PM on December 17, 2020: member

As Travis CI is no longer used, this PR:

drops travis_fold feature
drops mentions of Travis CI in docs

ci: Drop travis_fold feature as Travis CI is no longer used 09d105ef0f

in doc/release-process.md:310 in 4f286f8762 outdated

 306 | @@ -307,9 +307,9 @@ bitcoin.org (see below for bitcoin.org update instructions).
 307 |    - First, check to see if the Bitcoin.org maintainers have prepared a
 308 |      release: https://github.com/bitcoin-dot-org/bitcoin.org/labels/Core
 309 |  
 310 | -      - If they have, it will have previously failed their Travis CI
 311 | +      - If they have, it will have previously failed their Cirrus CI

MarcoFalke commented at 8:18 PM on December 17, 2020:

bitcoin(core).org is still using Travis

      - If they have, it will have previously failed their CI

hebasto commented at 11:23 PM on December 17, 2020:

Updated.

in test/functional/README.md:26 in 4f286f8762 outdated

  22 | @@ -23,7 +23,7 @@ don't have test cases for.
  23 |  - The oldest supported Python version is specified in [doc/dependencies.md](/doc/dependencies.md).
  24 |    Consider using [pyenv](https://github.com/pyenv/pyenv), which checks [.python-version](/.python-version),
  25 |    to prevent accidentally introducing modern syntax from an unsupported Python version.
  26 | -  The Travis linter also checks this, but [possibly not in all cases](https://github.com/bitcoin/bitcoin/pull/14884#discussion_r239585126).
  27 | +  The Cirrus CI linter job also checks this, but [possibly not in all cases](https://github.com/bitcoin/bitcoin/pull/14884#discussion_r239585126).

MarcoFalke commented at 8:19 PM on December 17, 2020:

no need to be overly specific

  The CI linter job also checks this, but [possibly not in all cases](https://github.com/bitcoin/bitcoin/pull/14884#discussion_r239585126).

hebasto commented at 11:23 PM on December 17, 2020:

Updated.

MarcoFalke commented at 8:20 PM on December 17, 2020: member

Might be better to just say CI, which can't be wrong

in doc/developer-notes.md:546 in 4f286f8762 outdated

 542 | @@ -543,7 +543,7 @@ General Bitcoin Core
 543 |    - *Rationale*: RPC allows for better automatic testing. The test suite for
 544 |      the GUI is very limited.
 545 |  
 546 | -- Make sure pull requests pass Travis CI before merging.
 547 | +- Make sure pull requests pass Cirrus CI before merging.

jonatack commented at 8:32 PM on December 17, 2020:

- Make sure pull requests pass CI before merging.

hebasto commented at 11:23 PM on December 17, 2020:

Updated.

jonatack commented at 8:35 PM on December 17, 2020: member

Concept ACK. I think you can just say CI instead of Cirrus CI everywhere you change here for less churn and maintenance. People see the CI sources in the PRs anyway. Maybe in one or two of the more official places you could optionally write CI (Continuous Integration) instead of just CI.

DrahtBot added the label Docs on Dec 17, 2020

DrahtBot added the label Tests on Dec 17, 2020

doc: Drop mentions of Travis CI as it is no longer used 95487b0553

hebasto force-pushed on Dec 17, 2020

hebasto commented at 11:22 PM on December 17, 2020: member

Updated 4f286f8762e49d2a31653dbfdba80fb300b06ba4 -> 95487b055328b590ba83f258de9637ab0f9a2f17 (pr20691.01 -> pr20691.02, diff):

addressed all of @MarcoFalke's and @jonatack's comments

MarcoFalke commented at 6:22 AM on December 18, 2020: member

ACK 95487b055328b590ba83f258de9637ab0f9a2f17

DrahtBot commented at 6:27 AM on December 18, 2020: member

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#20682 (ci: Install missing lint packages by MarcoFalke)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

MarcoFalke merged this on Dec 18, 2020

MarcoFalke closed this on Dec 18, 2020

hebasto deleted the branch on Dec 18, 2020

sidhujag referenced this in commit 0d39448c01 on Dec 18, 2020

fanquake locked this on Dec 29, 2020