rpc: Replace boost::variant with std::variant for RPCArg.m_fallback #20736

1. 
   MarcoFalke commented at 1:24 pm on December 21, 2020: member

   Now that we can use std::variant from the vanilla standard library, drop the third-party boost variant dependency.

   Patch is split out from #20480. A step-by-step replacement is possible because we don’t have our own Variant wrapper and the source code specifies boost::variant explicitly. I think a step-by-step replacement should be preferred, because it simplifies review.

2. fanquake added the label Refactoring on Dec 21, 2020
3. fanquake added the label RPC/REST/ZMQ on Dec 21, 2020
4. MarcoFalke force-pushed on Dec 21, 2020
5. MarcoFalke force-pushed on Dec 21, 2020
6. 
   DrahtBot commented at 2:34 am on December 22, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #20480 (Replace boost::variant with std::variant by MarcoFalke)
   • #19288 (fuzz: Add fuzzing harness for TorController by practicalswift)
   • #19183 ([WIP DONOTMERGE] Replace boost with C++17 by MarcoFalke)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. 
   practicalswift commented at 3:02 am on December 22, 2020: contributor

   Concept ACK
8. in src/rpc/util.h:25 in fa82f00e62 outdated

   18@@ -19,6 +19,7 @@
   19 #include <util/check.h>
   20 
   21 #include <string>
   22+#include <variant>
   23 #include <vector>
   24 
   25 #include <boost/variant.hpp>
   

   ---

   ---

   

   Sjors commented at 2:25 pm on December 30, 2020:

   You can drop #include <boost/variant.hpp>.

   ---

   

   MarcoFalke commented at 2:09 pm on January 1, 2021:

   Thanks, fixed.
9. Sjors changes_requested
10. 
    Sjors commented at 2:28 pm on December 30, 2020: member

    ACK fa82f00 modulo include
11. 
    fjahr commented at 1:08 pm on January 1, 2021: member

    ACK fa82f00 modulo include as @Sjors mentioned

    I had started working on the same change before I found this and ended up with almost the same changeset for this part of the variant usage code.

12. rpc: Replace boost::variant with std::variant for RPCArg.m_fallback fa749fbea3
13. MarcoFalke force-pushed on Jan 1, 2021
14. 
    fjahr commented at 2:41 pm on January 1, 2021: member

    re-ACK fa749fbea3cad64582f76f7a58cfcc0d91a97326
15. 
    Sjors commented at 7:11 pm on January 1, 2021: member

    re-ACK fa749fbea3cad64582f76f7a58cfcc0d91a97326
16. MarcoFalke merged this on Jan 4, 2021
17. MarcoFalke closed this on Jan 4, 2021

    ---

18. MarcoFalke deleted the branch on Jan 4, 2021
19. sidhujag referenced this in commit 2e6fb6f50e on Jan 4, 2021
20. DrahtBot locked this on Aug 16, 2022

Contributors
MarcoFalke DrahtBot practicalswift Sjors fjahr

Labels
Refactoring RPC/REST/ZMQ