fuzz: Check that NULL_DATA is unspendable #20761

1. 
   MarcoFalke commented at 1:10 pm on December 24, 2020: member

   • Every script of type NULL_DATA must be unspendable
   • The only know types of unspendable scripts are NULL_DATA and certain NONSTANDARD scripts
2. fanquake added the label Tests on Dec 24, 2020
3. fuzz: Check that NULL_DATA is unspendable fa26303286
4. MarcoFalke force-pushed on Dec 24, 2020
5. in src/test/fuzz/script.cpp:85 in fa26303286

   88@@ -82,7 +89,6 @@ FUZZ_TARGET_INIT(script, initialize_script)
   89     (void)script.IsPayToScriptHash();
   90     (void)script.IsPayToWitnessScriptHash();
   91     (void)script.IsPushOnly();
   92-    (void)script.IsUnspendable();
   

   ---

   ---

   

   murtyjones commented at 2:46 pm on December 24, 2020:

   What do these lines do? Push the output to solutions?

   ---

   

   sipa commented at 3:01 am on December 25, 2020:

   Nothing. They increase coverage.
6. mjdietzx approved
7. 
   mjdietzx commented at 7:07 pm on December 24, 2020: contributor

   Ack fa2630328687645fbc7dd1ea46aac32514025715
8. 
   DrahtBot commented at 0:13 am on December 25, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #20765 (fuzz: check that certain script TxoutType are nonstandard by mjdietzx)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

9. 
   sipa commented at 3:02 am on December 25, 2020: member

   utACK fa2630328687645fbc7dd1ea46aac32514025715
10. MarcoFalke merged this on Dec 25, 2020
11. MarcoFalke closed this on Dec 25, 2020

    ---

12. MarcoFalke deleted the branch on Dec 25, 2020
13. sidhujag referenced this in commit 619e064ec0 on Dec 25, 2020
14. 
    practicalswift commented at 7:59 pm on December 27, 2020: contributor

    Post-merge ACK

    Thanks for improving the fuzzing harnesses!

15. 
    luke-jr commented at 1:22 am on January 3, 2021: member

    Post-merge utACK
16. MarcoFalke referenced this in commit 2dab2d239a on Jan 3, 2021
17. sidhujag referenced this in commit 560045c438 on Jan 3, 2021
18. PastaPastaPasta referenced this in commit 6530682b84 on Apr 3, 2022
19. DrahtBot locked this on Aug 16, 2022

Contributors
MarcoFalke murtyjones sipa mjdietzx DrahtBot practicalswift luke-jr

Labels
Tests