fuzz: bolster ExtractDestination(s) checks #20772

1. 
   mjdietzx commented at 3:31 pm on December 26, 2020: contributor
2. DrahtBot added the label Tests on Dec 26, 2020
3. 
   DrahtBot commented at 6:05 pm on December 26, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   No conflicts as of last run.

4. mjdietzx force-pushed on Dec 26, 2020
5. DrahtBot added the label Needs rebase on Dec 26, 2020
6. mjdietzx force-pushed on Dec 27, 2020
7. DrahtBot removed the label Needs rebase on Dec 27, 2020
8. mjdietzx force-pushed on Dec 27, 2020
9. in src/test/fuzz/script.cpp:62 in 0a7f327027 outdated

   67-    (void)InferDescriptor(script, signing_provider);
   68-
   69-    (void)IsSegWitOutput(signing_provider, script);
   70-
   71-    (void)IsSolvable(signing_provider, script);
   72+    if (!ExtractDestinations(script, type_ret, addresses, required_ret)) {
   

   ---

   ---

   

   sipa commented at 5:02 am on December 27, 2020:

   This code could be significantly more efficient by just calling ExtractDestination(s) once each, caching the result, and then making assertions on those results.
10. 
    sipa commented at 5:03 am on December 27, 2020: member

    Concept ACK, but probably not worth spending too much time on if ExtractDestinations is going away anyway.
11. 
    practicalswift commented at 10:39 pm on December 27, 2020: contributor

    Concept ACK

    Thanks for improving the fuzzing harnesses!

12. mjdietzx force-pushed on Dec 29, 2020
13. fuzz: bolster ExtractDestination(s) checks a29f522ba4
14. mjdietzx force-pushed on Jan 3, 2021
15. 
    mjdietzx commented at 5:40 pm on January 3, 2021: contributor

    rebased to master - fixed conflicts after #20765 was merged
16. in src/test/fuzz/script.cpp:75 in a29f522ba4

    80+                   type_ret == TxoutType::NONSTANDARD ||
    81+                   type_ret == TxoutType::NULL_DATA);
    82+        }
    83+    } else {
    84+        assert(required_ret >= 1 && required_ret <= 16);
    85+        assert((unsigned long)required_ret == addresses.size());
    

    ---

    ---

    

    practicalswift commented at 10:36 pm on March 20, 2021:

    Nit: size_t instead of unsigned long to match the return type of size()?
17. 
    practicalswift commented at 10:38 pm on March 20, 2021: contributor

    Tested ACK a29f522ba4aa71582b54025c5682b4c1687ae9f3

    Thanks for adding assertions to existing fuzzing harnesses: that’s a great way to improve the value provided by them!

    Feel free to ignore nit.

18. 
    adamjonas commented at 5:13 pm on April 27, 2021: member

    Tested a29f522ba4aa71582b54025c5682b4c1687ae9f3 with FUZZ=script src/test/fuzz/fuzz qa-assets/fuzz_seed_corpus/script. No problems.
19. MarcoFalke merged this on Apr 28, 2021
20. MarcoFalke closed this on Apr 28, 2021

    ---

21. sidhujag referenced this in commit 095694c116 on Apr 28, 2021
22. gwillen referenced this in commit ae471dc6a5 on Jun 1, 2022
23. DrahtBot locked this on Aug 18, 2022

Contributors
mjdietzx DrahtBot sipa practicalswift adamjonas

Labels
Tests