net, p2p, gui: replace direction with connection type in gui peer details window #20778

1. 
   jonatack commented at 10:28 pm on December 26, 2020: member

   This is a migration of https://github.com/bitcoin-core/gui/pull/163 @ 3707f8c (#163) to this repo. The initial version of the pull only changed gui code; however, reviewers suggested changes and refactoring that involve this repo, so I’ve ported it here. Please see the original pull for the review up to this point. Closes https://github.com/bitcoin-core/gui/issues/159.

   

2. net: expose CNode::m_conn_type in CNodeStats a60f67b2fb
3. gui: create GUIUtil::ConnectionTypeToQString utility function 4335c4fd28
4. gui: replace Direction with Connection Type in peer details 8e7f82a6a8
5. gui: improve connection type tooltip 6cd242c50f
6. p2p, rpc, refactor: remove CNodeStats::m_conn_type_string 3707f8c508
7. DrahtBot added the label GUI on Dec 26, 2020
8. DrahtBot added the label P2P on Dec 26, 2020
9. DrahtBot added the label RPC/REST/ZMQ on Dec 26, 2020
10. 
    DrahtBot commented at 11:40 pm on December 26, 2020: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #20779 (net, rpc, gui: add network to peers window and peer details by jonatack)
    • #20373 (refactor, net: Increase CNode data member encapsulation by hebasto)
    • #20210 (net: assert CNode::m_inbound_onion is inbound in ctor, add getter, unit tests by jonatack)
    • #19460 (multiprocess: Add bitcoin-wallet -ipcconnect option by ryanofsky)
    • #10102 ([experimental] Multiprocess bitcoin by ryanofsky)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

11. 
    jonatack commented at 3:05 pm on December 28, 2020: member

    Apparently following the CONTRIBUTING.md guide isn’t the right way to go about this.

    Up for grabs.

12. jonatack closed this on Dec 28, 2020

    ---

13. DrahtBot locked this on Feb 15, 2022

Contributors
jonatack DrahtBot

Labels
GUI RPC/REST/ZMQ P2P