net: [refactor] Prefer integral types in CNodeStats #20786

1. 
   MarcoFalke commented at 3:15 pm on December 28, 2020: member

   Currently, strings are stored for what are actually integral (strong) enum types. This is fine, because the strings are only used as-is for the debug log and RPC. However, it complicates using them in the GUI. User facing strings in the GUI should be translated and only string literals can be picked up for translation, not runtime std::strings.

   Fix that by removing the std::string members and replace them by strong enum integral types.

2. 
   MarcoFalke commented at 3:16 pm on December 28, 2020: member

   Picked up from #20778 and #20779 . Credits go to @jonatack

3. fanquake added the label P2P on Dec 28, 2020
4. fanquake added the label Refactoring on Dec 28, 2020
5. 
   DrahtBot commented at 5:09 pm on December 28, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   No conflicts as of last run.

6. 
   practicalswift commented at 9:05 pm on December 28, 2020: contributor

   Concept ACK
7. 
   promag commented at 10:32 pm on December 28, 2020: member

   ACK 7f126f2da6.
8. MarcoFalke force-pushed on Dec 29, 2020
9. MarcoFalke force-pushed on Dec 29, 2020
10. MarcoFalke force-pushed on Dec 29, 2020
11. MarcoFalke force-pushed on Dec 29, 2020
12. 
    ajtowns commented at 2:05 am on December 30, 2020: member

    Concept ACK.
13. 
    FndNur1Labs commented at 3:17 am on December 30, 2020: none

    Rebased ok.
14. DrahtBot added the label Needs rebase on Jan 2, 2021
15. MarcoFalke force-pushed on Jan 2, 2021
16. DrahtBot removed the label Needs rebase on Jan 2, 2021
17. promag approved
18. 
    promag commented at 6:21 pm on January 2, 2021: member

    Code review ACK 6e7e053a94829dbbdcede5cc27c78142dca85aef.
19. Expose integral m_conn_type in CNodeStats, remove m_conn_type_string faecb74562
20. MarcoFalke force-pushed on Jan 7, 2021
21. 
    MarcoFalke commented at 2:20 pm on January 7, 2021: member

    Rebased due to trivial conflict in adjacent line
22. MarcoFalke deleted a comment on Jan 7, 2021
23. 
    jonatack commented at 7:39 pm on January 7, 2021: member

    Code review ACK faecb74562d012a336837d3b39572c235ad2eb9d
24. theStack approved
25. 
    theStack commented at 2:12 pm on January 8, 2021: member

    LGTM Code review ACK faecb74562d012a336837d3b39572c235ad2eb9d 🌲
26. MarcoFalke merged this on Jan 8, 2021
27. MarcoFalke closed this on Jan 8, 2021

    ---

28. MarcoFalke deleted the branch on Jan 8, 2021
29. sidhujag referenced this in commit 5e1af32137 on Jan 8, 2021
30. luke-jr referenced this in commit 11a9378aad on Jan 28, 2021
31. DrahtBot locked this on Aug 16, 2022

Contributors
MarcoFalke DrahtBot practicalswift promag ajtowns FndNur1Labs jonatack theStack

Labels
Refactoring P2P