p2p: remove unused legacyWhitelisted in AcceptConnection() #20791

1. 
   jonatack commented at 11:56 pm on December 28, 2020: member

   Noticed while compiling master:

   0net.cpp: In member function ‘void CConnman::AcceptConnection(const CConnman::ListenSocket&)’:
   1net.cpp:1041:10: warning: variable ‘legacyWhitelisted’ set but not used [-Wunused-but-set-variable]
   2 1041 |     bool legacyWhitelisted = false;
   3      |          ^~~~~~~~~~~~~~~~~
   

2. p2p: remove unused legacyWhitelisted variable 8f9ca31782
3. fanquake added the label P2P on Dec 28, 2020
4. 
   jonatack commented at 11:59 pm on December 28, 2020: member

   Curious that I didn’t see this before. It’s very late but will look at the context tomorrow how this became orphaned.
5. jonatack renamed this:
   p2p: remove unused legacyWhitelisted bool variable
   p2p: remove unused legacyWhitelisted in AcceptConnection()
   on Dec 29, 2020
6. 
   glozow commented at 0:30 am on December 29, 2020: member

   utACK https://github.com/bitcoin/bitcoin/pull/20791/commits/8f9ca31782372fb60377ef319fefd727bb8c5d75

   I think this is leftover from #20755 (from this comment about it), looks like you saw it like 2 hours after merge hahaha

7. 
   jonatack commented at 0:37 am on December 29, 2020: member

   Ah, it’s from b1a936d4ae7dd90
8. 
   jonatack commented at 0:39 am on December 29, 2020: member

   Thanks @glozow! Looks like we arrived at the same source in different ways.
9. 
   mjdietzx commented at 3:37 am on December 29, 2020: contributor

   ack 8f9ca31782372fb60377ef319fefd727bb8c5d75
10. 
    MarcoFalke commented at 7:55 am on December 29, 2020: member

    Looks like gcc is required to get this warning. Using clang version 11.0.0 doesn’t say anything.
11. 
    MarcoFalke commented at 7:55 am on December 29, 2020: member

    review ACK 8f9ca31782372fb60377ef319fefd727bb8c5d75
12. MarcoFalke added the label Refactoring on Dec 29, 2020
13. MarcoFalke merged this on Dec 29, 2020
14. MarcoFalke closed this on Dec 29, 2020

    ---

15. jonatack deleted the branch on Dec 29, 2020
16. sidhujag referenced this in commit df49744c51 on Dec 29, 2020
17. 
    practicalswift commented at 7:08 pm on December 29, 2020: contributor

    Post merge ACK: thanks for cleaning up! :)
18. DrahtBot locked this on Feb 15, 2022

Contributors
jonatack glozow mjdietzx MarcoFalke practicalswift

Labels
Refactoring P2P