p2p: remove unused legacyWhitelisted in AcceptConnection() #20791

pull jonatack wants to merge 1 commits into bitcoin:master from jonatack:rm-unused-legacyWhitelisted changing 1 files +0 −2

jonatack commented at 11:56 PM on December 28, 2020: member

Noticed while compiling master:

net.cpp: In member function ‘void CConnman::AcceptConnection(const CConnman::ListenSocket&)’:
net.cpp:1041:10: warning: variable ‘legacyWhitelisted’ set but not used [-Wunused-but-set-variable]
 1041 |     bool legacyWhitelisted = false;
      |          ^~~~~~~~~~~~~~~~~

p2p: remove unused legacyWhitelisted variable 8f9ca31782
fanquake added the label P2P on Dec 28, 2020
jonatack commented at 11:59 PM on December 28, 2020: member

Curious that I didn't see this before. It's very late but will look at the context tomorrow how this became orphaned.
jonatack renamed this:
~~p2p: remove unused legacyWhitelisted bool variable~~
p2p: remove unused legacyWhitelisted in AcceptConnection()
on Dec 29, 2020
glozow commented at 12:30 AM on December 29, 2020: member

utACK https://github.com/bitcoin/bitcoin/pull/20791/commits/8f9ca31782372fb60377ef319fefd727bb8c5d75

I think this is leftover from #20755 (from this comment about it), looks like you saw it like 2 hours after merge hahaha
jonatack commented at 12:37 AM on December 29, 2020: member

Ah, it's from b1a936d4ae7dd90
jonatack commented at 12:39 AM on December 29, 2020: member

Thanks @glozow! Looks like we arrived at the same source in different ways.
mjdietzx commented at 3:37 AM on December 29, 2020: contributor

ack 8f9ca31782372fb60377ef319fefd727bb8c5d75
MarcoFalke commented at 7:55 AM on December 29, 2020: member

Looks like gcc is required to get this warning. Using clang version 11.0.0 doesn't say anything.
MarcoFalke commented at 7:55 AM on December 29, 2020: member

review ACK 8f9ca31782372fb60377ef319fefd727bb8c5d75
MarcoFalke added the label Refactoring on Dec 29, 2020
MarcoFalke merged this on Dec 29, 2020
MarcoFalke closed this on Dec 29, 2020
jonatack deleted the branch on Dec 29, 2020
sidhujag referenced this in commit df49744c51 on Dec 29, 2020
practicalswift commented at 7:08 PM on December 29, 2020: contributor

Post merge ACK: thanks for cleaning up! :)
DrahtBot locked this on Feb 15, 2022

Contributors

Labels