Qt trusts untrustworthy paths on Windows #20802

issue luke-jr opened this issue on December 29, 2020
  1. luke-jr commented at 11:01 PM on December 29, 2020: member

    Qt looks in C:\ProgramData\... for MIME and logging configuration files on Windows. This path is intended to be writable by all users on the system ("/tmp"-like), so any user could create these files.

    It does not appear this is currently dangerous; there is a DoS threat, but a local user could just as well shut down the machine to achieve the same thing.

    However, it would be best to avoid letting other users reconfigure anything if possible. Unfortunately, I don't see any way to tell Qt not to do this.

    Since we have chosen to ignore worse multiuser compromises (eg, CVE-2018-20587), it seems likely this issue can just be ignored until some future time where fixing it is more practical. However, any Qt depends bumps should probably be audited to ensure this vulnerability does not create a dangerous situation due to new usage of C:\ProgramData (eg, we wouldn't want to load random DLLs found there).

    Initially reported by Xavier Danest and analysed also by @laanwj and @sipsorcery

  2. luke-jr added the label Bug on Dec 29, 2020
  3. fanquake added the label Windows on Dec 30, 2020
  4. laanwj commented at 8:05 AM on December 30, 2020: member

    Since we have chosen to ignore worse multiuser compromises (eg, CVE-2018-20587),

    To be fair we didn't ignore it. I tried to fix that in #14968. It's just such an awful mess to fix with libevent, so it was eventually decided the current state of things is the least worst one.

  5. luke-jr commented at 4:43 PM on December 30, 2020: member

    I meant the end outcome [so far], not the people. :)

  6. wumpus commented at 5:24 PM on December 30, 2020: none

    Wrong @wumpus.

  7. luke-jr commented at 6:32 PM on December 30, 2020: member

    oops, sorry, fixed attribution

  8. willcl-ark commented at 4:32 PM on September 21, 2023: member

    Please can you re-open this in the GUI repo if it's still an issue.

  9. willcl-ark closed this on Sep 21, 2023

  10. bitcoin locked this on Sep 20, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 15:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me