script: Improve robustness of bitcoind.service on startup #20884

pull hebasto wants to merge 3 commits into bitcoin:master from hebasto:210108-systemd changing 2 files +7 −3

hebasto commented at 4:09 PM on January 8, 2021: member

If network interfaces are not properly up the following happens:

...
2021-01-08T10:17:11Z scheduler thread start
2021-01-08T10:17:11Z libevent: getaddrinfo: address family for nodename not supported
2021-01-08T10:17:11Z Binding RPC on address 127.0.0.1 port 8332 failed.
2021-01-08T10:17:11Z HTTP: creating work queue of depth 16
2021-01-08T10:17:11Z Using random cookie authentication.
2021-01-08T10:17:11Z Generated RPC authentication cookie /var/lib/bitcoind/.cookie
2021-01-08T10:17:11Z HTTP: starting 2 worker threads
2021-01-08T10:17:11Z init message: Loading banlist...
2021-01-08T10:17:11Z SetNetworkActive: true
2021-01-08T10:17:11Z Error: Cannot resolve -externalip address: <EDITED>
2021-01-08T10:17:11Z Shutdown: In progress...
2021-01-08T10:17:11Z scheduler thread exit
2021-01-08T10:17:11Z Shutdown: done

This PR improves robustness on startup in such cases in documented way: https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/

Also minor doc improvements are added.

script: Improve robustness of bitcoind.service on startup d9392b724c
script: Add Documentation key to bitcoind.service 601778c310
doc: Fix systemd spelling and link to doc/init.md
See https://www.freedesktop.org/wiki/Software/systemd/
9d02654677
DrahtBot added the label Docs on Jan 8, 2021
DrahtBot added the label Scripts and tools on Jan 8, 2021
in contrib/init/bitcoind.service:14 in 601778c310 outdated
```
  10 | @@ -11,6 +11,7 @@
  11 |  
  12 |  [Unit]
  13 |  Description=Bitcoin daemon
  14 | +Documentation=https://github.com/bitcoin/bitcoin/blob/master/doc/init.md
```
Sjors commented at 5:28 PM on January 8, 2021:

For other reviewers: https://www.freedesktop.org/software/systemd/man/systemd.unit.html#Documentation=

darosior commented at 10:05 PM on January 9, 2021:

https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/#cutthecraphowdoimakesurethatmyservicestartsafterthenetworkisreallyonline :p
Sjors commented at 5:29 PM on January 8, 2021: member

ACK 9d02654

I've been using the same modification for at least a year.
brunoerg approved
practicalswift commented at 5:43 PM on January 9, 2021: contributor

ACK 9d026546778629472574b26fa73338efc63d02da: patch looks correct
darosior approved
darosior commented at 10:06 PM on January 9, 2021: member

ACK 9d026546778629472574b26fa73338efc63d02da -- been using the first patch too
in contrib/init/bitcoind.service:14 in 9d02654677
```
  10 | @@ -11,7 +11,11 @@
  11 |  
  12 |  [Unit]
  13 |  Description=Bitcoin daemon
  14 | -After=network.target
  15 | +Documentation=https://github.com/bitcoin/bitcoin/blob/master/doc/init.md
```
luke-jr commented at 6:55 PM on January 11, 2021:

Is there a way to cleanly link to the local file instead of github?

hebasto commented at 9:07 PM on January 11, 2021:

idk about such a way. Have you any concerns about a link to the file in the github repo? If so, I could drop this change.
RiccardoMasutti approved
RiccardoMasutti commented at 2:34 PM on January 15, 2021: contributor

ACK
laanwj merged this on Jan 18, 2021
laanwj closed this on Jan 18, 2021
hebasto deleted the branch on Jan 18, 2021
sidhujag referenced this in commit 1434ae2e04 on Jan 20, 2021
DrahtBot locked this on Aug 16, 2022

Contributors

Labels

Docs Scripts and tools