doc: Add explicit macdeployqtplus dependencies install step #20890

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:210108-deploy changing 1 files +5 −0
  1. hebasto commented at 9:59 pm on January 8, 2021: member

    This PR adds to macOS docs an explicit step to install macdeployqtplus script dependencies that are not part of the Python Standard Library:

    This change is required on macOS 11 Big Sur:

    Close #20878.

  2. hebasto force-pushed on Jan 8, 2021
  3. hebasto force-pushed on Jan 8, 2021
  4. DrahtBot added the label Docs on Jan 8, 2021
  5. jarolrod commented at 0:41 am on January 9, 2021: member

    ACK aaa7b294f8323b0087b090180819aeadcf42a826

    Confirming that without installing argparse, ds_store, mac_alias, make deploy fails on macOS Big Sur 11.1.

    Deploying DMG is successful after installing these packages with pip3.

  6. in doc/build-osx.md:35 in aaa7b294f8 outdated
    29@@ -30,6 +30,11 @@ If you want to build the disk image with `make deploy` (.dmg / optional), you ne
    30 brew install librsvg
    31 ```
    32 
    33+and [`macdeployqtplus`](../contrib/macdeploy/README.md) dependencies:
    34+```shell
    35+pip3 install argparse ds_store mac_alias
    


    fanquake commented at 1:51 am on January 9, 2021:
    argparse is part of the Python standard library. It doesn’t need installing.

    hebasto commented at 7:38 am on January 9, 2021:

    argparse is part of the Python standard library.

    Indeed: https://docs.python.org/3/library/argparse.html

    It doesn’t need installing.

    Fixed.

  7. fanquake changes_requested
  8. doc: Add explicit macdeployqtplus dependencies install step
    This change is required on macOS 11 Big Sur.
    3e61b8c800
  9. hebasto force-pushed on Jan 9, 2021
  10. hebasto commented at 7:59 am on January 9, 2021: member

    Updated aaa7b294f8323b0087b090180819aeadcf42a826 -> 3e61b8c800180d350621cedda7ec46a48047ff04 (pr20890.02 -> pr20890.03, diff):

    argparse is part of the Python standard library. It doesn’t need installing.

  11. fanquake approved
  12. fanquake commented at 7:02 am on January 10, 2021: member

    ACK 3e61b8c800180d350621cedda7ec46a48047ff04

    This change is required on macOS 11 Big Sur:

    There’s nothing macOS 11 specific about this doc addition. The same dependencies & dmg creation process is used you run make deploy on macOS 10.

  13. fanquake merged this on Jan 10, 2021
  14. fanquake closed this on Jan 10, 2021

  15. hebasto deleted the branch on Jan 10, 2021
  16. sidhujag referenced this in commit 1cd3c7b845 on Jan 10, 2021
  17. random-zebra referenced this in commit fbebade1e4 on Jun 11, 2021
  18. DrahtBot locked this on Aug 16, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-05 19:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me