MAX_BLOCK_BASE_SIZE should be removed in functional tests as well ? #20930

issue tannn92 opened this issue on January 14, 2021

tannn92 commented at 4:03 AM on January 14, 2021: none

I can see that @sipa pushed a commit to Remove confusing MAX_BLOCK_BASE_SIZE (3babbcb48), by the way, I still can see the use of it in a lot of functional tests (p2p_segwit, mempool_accept...), do these test cases still make any sense? Should we remove them as well?
tannn92 added the label Feature on Jan 14, 2021
tannn92 closed this on Jan 14, 2021
tannn92 reopened this on Jan 14, 2021
tannn92 commented at 8:49 AM on January 14, 2021: none

My mistake, it's @gmaxwell who removed it.
tannn92 closed this on Jan 15, 2021
tannn92 commented at 3:22 AM on January 15, 2021: none

Move to #20940 since I cannot edit the incorrect tag Feature
fanquake locked this on Jan 15, 2021
fanquake removed the label Feature on Jan 16, 2021

Contributors