gitian-keys: Add signer aliases, some historical keys #20958

laanwj commented at 6:04 PM on January 18, 2021: member

Update keys.txt for gitian-verify.py (bitcoin-core/bitcoin-maintainer-tools#71)

Extend line format with signer aliases in parentheses
Add a few historical signers
Sort the file by name

Co-authored-by: fanquake fanquake@gmail.com

laanwj added the label Scripts and tools on Jan 18, 2021

laanwj requested review from Sjors on Jan 18, 2021

jonatack commented at 10:19 PM on January 18, 2021: member

Concept ACK.

in contrib/gitian-keys/keys.txt:12 in 04d9e08dde outdated

   8 |  912FD3228387123DC97E0E57D5566241A0295FA9 BtcDrak
   9 |  C519EBCF3B926298946783EFF6430754120EC2F4 Christian Decker (cdecker)
  10 | +18AE2F798E0D239755DA4FD24B79F986CBDF8736 Chun Kuan Le (ken2812221)
  11 |  F20F56EF6A067F70E8A5C99FFF95FAA971697405 centaur
  12 | -C060A6635913D98A3587D7DB1C2491FFEB0EF770 Cory Fields
  13 | +C060A6635913D98A3587D7DB1C2491FFEB0EF770 Cory Fields (cfields)

jonatack commented at 10:24 PM on January 18, 2021:

maybe, per https://github.com/bitcoin-core/gitian.sigs/commits?author=theuni

C060A6635913D98A3587D7DB1C2491FFEB0EF770 Cory Fields (cfields, theuni)

laanwj commented at 11:43 AM on January 19, 2021:

gitian.sigs$ git ls-files|grep -i /theuni/
[nothing]

in contrib/gitian-keys/keys.txt:18 in 04d9e08dde outdated

  15 | -6D3170C1DC2C6FD0AEEBCA6743811D1A26623924 Douglas Roark
  16 | +6D3170C1DC2C6FD0AEEBCA6743811D1A26623924 Douglas Roark (droark)
  17 | +1C6621605EC50319C463D56C7F81D87985D61612 Emanuele Cisbani (cisba)
  18 |  9A1689B60D1B3CCE9262307A2F40A9BF167FBA47 Erik Mossberg (erkmos)
  19 |  D35176BE9264832E4ACA8986BF0792FBE95DC863 fivepiece
  20 | +6F993B250557E7B016ADE5713BDCDA2D87A881D9 Fuzzbawls (Fuzzbawls)

jonatack commented at 10:26 PM on January 18, 2021:

seems redundant

laanwj commented at 11:39 AM on January 19, 2021:

It's not. The script ignores the "real name" (the first part) only looks at the aliases in parentheses.

Edit: I guess that could be changed, though I think this is consistent at least, people are unlikely to use their name, with spaces in it, as gitian directory name.

in contrib/gitian-keys/keys.txt:18 in 04d9e08dde outdated

  16 | +6D3170C1DC2C6FD0AEEBCA6743811D1A26623924 Douglas Roark (droark)
  17 | +1C6621605EC50319C463D56C7F81D87985D61612 Emanuele Cisbani (cisba)
  18 |  9A1689B60D1B3CCE9262307A2F40A9BF167FBA47 Erik Mossberg (erkmos)
  19 |  D35176BE9264832E4ACA8986BF0792FBE95DC863 fivepiece
  20 | +6F993B250557E7B016ADE5713BDCDA2D87A881D9 Fuzzbawls (Fuzzbawls)
  21 |  01CDF4627A3B88AAE4A571C87588242FBE38D3A8 Gavin Andresen

jonatack commented at 10:27 PM on January 18, 2021:

maybe not needed currently, but

01CDF4627A3B88AAE4A571C87588242FBE38D3A8 Gavin Andresen (gavinandresen)

laanwj commented at 11:41 AM on January 19, 2021:

Sure, but did he ever do a gitian build?

Edit: yes, apparently e.g.

0.10.0rc1-osx-unsigned/gavinandresen/bitcoin-osx-0.10-build.assert

Edit2: doh of course he did, this is the gitian signers file everyone here did gitian builds, sorry

in contrib/gitian-keys/keys.txt:26 in 04d9e08dde outdated

  26 |  D3CC177286005BB8FF673294C5242A1AB3936517 jl2012
  27 | -82921A4B88FD454B7EB8CE3C796C4109063D4EAF Jon Atack
  28 | -32EE5C4C3FA15CCADB46ABE529D4BCB6416F53EC Jonas Schnelli
  29 | +82921A4B88FD454B7EB8CE3C796C4109063D4EAF Jon Atack (jonatack)
  30 | +32EE5C4C3FA15CCADB46ABE529D4BCB6416F53EC Jonas Schnelli (jonasschnelli)
  31 |  4B4E840451149DD7FB0D633477DFAB5C3108B9A8 Jorge Timon

jonatack commented at 10:27 PM on January 18, 2021:

4B4E840451149DD7FB0D633477DFAB5C3108B9A8 Jorge Timon (jtimon)

laanwj commented at 11:43 AM on January 19, 2021:

ACK, assuming he used the same key back then

$ git ls-files|grep -i /jtimon/
0.13.2-linux/jtimon/bitcoin-linux-0.13-build.assert
0.13.2-linux/jtimon/bitcoin-linux-0.13-build.assert.sig
0.13.2-win-unsigned/jtimon/bitcoin-win-0.13-build.assert
0.13.2-win-unsigned/jtimon/bitcoin-win-0.13-build.assert.sig

in contrib/gitian-keys/keys.txt:32 in 04d9e08dde outdated

  33 | -E463A93F5F3117EEDE6C7316BD02942421F4889F Luke Dashjr
  34 | -B8B3F1C0E58C15DB6A81D30C3648A882F4316B9B Marco Falke
  35 | +30DE693AE0DE9E37B3E7EB6BBFF0F67810C1EED1 Lisa Neigut (niftynei)
  36 | +E463A93F5F3117EEDE6C7316BD02942421F4889F Luke Dashjr (luke-jr)
  37 | +B8B3F1C0E58C15DB6A81D30C3648A882F4316B9B Marco Falke (marco)
  38 |  07DF3E57A548CCFB7530709189BBB8663E2E65CE Matt Corallo (BlueMatt)

jonatack commented at 10:29 PM on January 18, 2021:

maybe, per https://github.com/bitcoin-core/gitian.sigs/commits?author=TheBlueMatt

07DF3E57A548CCFB7530709189BBB8663E2E65CE Matt Corallo (TheBlueMatt)

laanwj commented at 11:40 AM on January 19, 2021:

That would be if he used that as directory name in gitian.sigs, but he used BlueMatt. It's not the github name, it's the signer alias as used for gitian.

gitian.sigs$ git ls-files|grep -i /thebluematt/
[nothing]

practicalswift commented at 9:31 AM on January 19, 2021: contributor

Concept ACK

laanwj force-pushed on Jan 19, 2021

laanwj commented at 12:18 PM on January 19, 2021: member

Updated per @jonatack's comments to add signer aliases for everyone I could find the directory name in gitian.sigs for.

laanwj force-pushed on Jan 19, 2021

laanwj commented at 4:42 PM on January 19, 2021: member

Updated to remove a key that was not used to sign any build result in gitian.sigs.

DrahtBot commented at 8:21 PM on January 22, 2021: member

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

Sjors approved

Sjors commented at 2:20 PM on January 23, 2021: member

Concept ACK

The signer aliases in 9d830c632f0be78f44f11871dd54e3babeb8dc4f look reasonable (my own is correct), but I didn't thoroughly check them.

gitian-keys: Add signer aliases, some historical keys

Co-authored-by: fanquake <fanquake@gmail.com>

2b4cfb44bd

laanwj force-pushed on Jan 24, 2021

laanwj commented at 6:02 PM on January 24, 2021: member

Rebased for #20989

laanwj merged this on Jan 24, 2021

laanwj closed this on Jan 24, 2021

DrahtBot locked this on Aug 16, 2022