Intermittent issue in create_raw_transaction assert_equal(final

MarcoFalke commented at 8:24 AM on January 21, 2021: member

https://cirrus-ci.com/task/4904241892425728?command=ci#L5098

 test  2021-01-20T23:39:58.801000Z TestFramework (ERROR): Assertion failed 
                                   Traceback (most recent call last):
                                     File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 126, in main
                                       self.run_test()
                                     File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/feature_nulldummy.py", line 94, in run_test
                                       test4tx = create_transaction(self.nodes[0], test2tx.hash, self.address, amount=46)
                                     File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/blocktools.py", line 164, in create_transaction
                                       raw_tx = create_raw_transaction(node, txid, to_address, amount=amount)
                                     File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/blocktools.py", line 180, in create_raw_transaction
                                       assert_equal(final_psbt["complete"], True)
                                     File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 50, in assert_equal
                                       raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
                                   AssertionError: not(False == True)

MarcoFalke added the label Bug on Jan 21, 2021

MarcoFalke added the label Tests on Jan 21, 2021

MarcoFalke commented at 8:25 AM on January 21, 2021: member

I've seen this for at least two months

hebasto commented at 2:06 PM on May 29, 2021: member

The same error in the recent "Linux32" build on https://bitcoinbuilds.org/?job=a67a5e50-f422-436f-b173-54a4765094db:

...
2021-05-29T13:54:49.294000Z TestFramework (INFO): Initializing test directory /tmp/test_runner_₿_🏃_20210529_093535/feature_nulldummy_72
2021-05-29T13:54:51.887000Z TestFramework (INFO): Test 1: NULLDUMMY compliant base transactions should be accepted to mempool and mined before activation [103]
2021-05-29T13:54:51.908000Z TestFramework (INFO): Test 2: Non-NULLDUMMY base multisig transaction should not be accepted to mempool before activation
2021-05-29T13:54:51.914000Z TestFramework (INFO): Test 3: Non-NULLDUMMY base transactions should be accepted in a block before activation [104]
2021-05-29T13:54:51.917000Z TestFramework (INFO): Test 4: Non-NULLDUMMY base multisig transaction is invalid after activation
2021-05-29T13:54:51.920000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/home/ubuntu/src/test/functional/test_framework/test_framework.py", line 128, in main
    self.run_test()
  File "/home/ubuntu/src/test/functional/feature_nulldummy.py", line 95, in run_test
    test4tx = create_transaction(self.nodes[0], test2tx.hash, self.address, amount=46)
  File "/home/ubuntu/src/test/functional/test_framework/blocktools.py", line 165, in create_transaction
    raw_tx = create_raw_transaction(node, txid, to_address, amount=amount)
  File "/home/ubuntu/src/test/functional/test_framework/blocktools.py", line 181, in create_raw_transaction
    assert_equal(final_psbt["complete"], True)
  File "/home/ubuntu/src/test/functional/test_framework/util.py", line 50, in assert_equal
    raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
AssertionError: not(False == True)
2021-05-29T13:54:51.971000Z TestFramework (INFO): Stopping nodes
...

MarcoFalke commented at 1:20 PM on June 1, 2021: member

@achow101 What info would be useful to debug this? Maybe log the full psbt?

achow101 commented at 6:08 PM on June 1, 2021: member

I think the full psbts and listunspent would help.

MarcoFalke referenced this in commit faa94961d6 on Jun 4, 2021

laanwj referenced this in commit 3c393ef9e1 on Jun 7, 2021

sidhujag referenced this in commit c2c645780f on Jun 9, 2021

ryanofsky commented at 2:37 PM on June 18, 2021: member

I saw this same issue yesterday: assert_equal(final_psbt["complete"], True) failing in feature_nulldummy.py) causing a spurious failure. Restarting cirrus got around the problem.

Failure: https://cirrus-ci.com/task/5801234834653184
Successful restart: https://cirrus-ci.com/task/4603201723826176

feature_nulldummy.py --descriptors

Checked out 33af67edbd902e9b9c3862c3a3066798cac1a33d on pull/22100 branch.

Traceback (most recent call last):
  File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 128, in main
    self.run_test()
  File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/feature_nulldummy.py", line 100, in run_test
    test4tx = create_transaction(self.nodes[0], test2tx.hash, self.address, amount=46)
  File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/blocktools.py", line 168, in create_transaction
    raw_tx = create_raw_transaction(node, txid, to_address, amount=amount)
  File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/blocktools.py", line 189, in create_raw_transaction
    assert_equal(final_psbt["complete"], True)

MarcoFalke commented at 2:42 PM on June 18, 2021: member

Details:

final_psbt={'psbt': 'cHNidP8BAFUCAAAAAd/Kfn8z41ORLq9mV3hJwLBljJSQTDUpGIiiPIPkfIdcAAAAAAD/////AQBuLhIBAAAAGXapFJsp8LQvoLFcyjgPWwVvhqgzFPcpiKwAAAAAAAEAwwIAAAABhFFT6REX/1w3WFGpdsAujrwcisumMDhLgCLShy+9HhgAAAAAcAFRRzBEAiAox4+9eI5Ga6KJtyxzQO/E8Uvs8GX/mWLe/NQ6SmvOVQIgeYUBZZEAIEIeX869NhsaT7q60V8e2JtF9N4B2i7ga84BJVEhAwkLetXZtuHFLbkEY53GpUhOPBdM5H1qX+YLwj1Zq1YaUa7/////AQBPJBgBAAAAF6kUuqIaInm3bupYERl5x/d+LEVeXOmHAAAAAAEEJVEhAwkLetXZtuHFLbkEY53GpUhOPBdM5H1qX+YLwj1Zq1YaUa4iBgMJC3rV2bbhxS25BGOdxqVITjwXTOR9al/mC8I9WatWGgSbKfC0ACICAwkLetXZtuHFLbkEY53GpUhOPBdM5H1qX+YLwj1Zq1YaGIeAfB8sAACAAQAAgAAAAIAAAAAAAAAAAAA=', 'complete': False} 

default_wallet listunspent=[{'txid': '3af53ae340d4fb08ce2ed0d2e1f25029546cce3a62ca686f4c014a7091ca175f', 'vout': 0, 'address': 'mjTkW3DjgyZck4KbiRusZsqTgaYTxdSz6z', 'scriptPubKey': '76a9142b4569203694fc997e13f2c0a1383b9e16c77a0d88ac', 'amount': Decimal('50.00000000'), 'confirmations': 102, 'spendable': True, 'solvable': True, 'desc': 'pkh([2b456920]0227d85ba011276cf25b51df6a188b75e604b38770a462b2d0e9fb2fc839ef5d3f)#mx6z3m4v', 'safe': True}, {'txid': '2baf157b6b03ebf7b9dde678f0ee99780dd494434b95b6a4d99f68de65f1599d', 'vout': 0, 'address': 'mjTkW3DjgyZck4KbiRusZsqTgaYTxdSz6z', 'scriptPubKey': '76a9142b4569203694fc997e13f2c0a1383b9e16c77a0d88ac', 'amount': Decimal('50.00000000'), 'confirmations': 101, 'spendable': True, 'solvable': True, 'desc': 'pkh([2b456920]0227d85ba011276cf25b51df6a188b75e604b38770a462b2d0e9fb2fc839ef5d3f)#mx6z3m4v', 'safe': True}]

wmulti listunspent=[{'txid': '5d09a3b937d8120dbe336445aa65964a3b49d9801b3b9c6af69412eed6026a2b', 'vout': 0, 'address': '2MsKJGT9e2WJCi12Zea6DmnhpZd5v58uU6K', 'label': '', 'redeemScript': '0020d3c63b927c6f8c7120ee3f99266ffc4ea8b85182b1aab02ef7cc69f813e7bebe', 'witnessScript': '512103090b7ad5d9b6e1c52db904639dc6a5484e3c174ce47d6a5fe60bc23d59ab561a51ae', 'scriptPubKey': 'a91400c53c4e5de32e46bc029b528bd75f8efc4de8c487', 'amount': Decimal('49.00000000'), 'confirmations': 2, 'spendable': True, 'solvable': True, 'desc': 'sh(wsh(multi(1,[9b29f0b4]03090b7ad5d9b6e1c52db904639dc6a5484e3c174ce47d6a5fe60bc23d59ab561a)))#hglknwc6', 'safe': True}, {'txid': '5c877ce4833ca2881829354c90948c65b0c049785766af2e9153e3337f7ecadf', 'vout': 0, 'address': '2NAG3s1pdyHLgfcNCEvxYPoqo9Jt6TB9KGV', 'label': '', 'redeemScript': '512103090b7ad5d9b6e1c52db904639dc6a5484e3c174ce47d6a5fe60bc23d59ab561a51ae', 'scriptPubKey': 'a914baa21a2279b76eea58111979c7f77e2c455e5ce987', 'amount': Decimal('47.00000000'), 'confirmations': 1, 'spendable': True, 'solvable': True, 'desc': 'sh(multi(1,[9b29f0b4]03090b7ad5d9b6e1c52db904639dc6a5484e3c174ce47d6a5fe60bc23d59ab561a))#ld9lxhr8', 'safe': True}]

MarcoFalke commented at 2:46 PM on June 18, 2021: member

Looks like a missing BlockUntilSyncedToCurrentChain in walletprocesspsbt and other methods

MarcoFalke removed the label Tests on Jun 18, 2021

MarcoFalke added the label Wallet on Jun 18, 2021

MarcoFalke added this to the milestone 22.0 on Jun 18, 2021

MarcoFalke referenced this in commit fa27baa9c8 on Jun 22, 2021

MarcoFalke referenced this in commit c93e123dc7 on Jun 22, 2021

MarcoFalke closed this on Jun 22, 2021

rebroad referenced this in commit e72129a63b on Jun 23, 2021

sidhujag referenced this in commit fc1ee5723c on Jun 24, 2021

josibake referenced this in commit 949c353b5d on Jul 21, 2021

promag referenced this in commit 75f5d74833 on Sep 28, 2021

DrahtBot locked this on Aug 18, 2022

Intermittent issue in create_raw_transaction assert_equal(final_psbt["complete"], True) fails #20975