Otherwise the suppressions file will go out of sync
ci: Fuzz with integer sanitizer #21012
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2101-fuzzIntSan changing 5 files +19 −10-
MarcoFalke commented at 12:05 PM on January 26, 2021: member
-
ci: Fuzz with integer sanitizer faff3991a9
- fanquake added the label Tests on Jan 26, 2021
-
practicalswift commented at 12:41 PM on January 26, 2021: contributor
Super Strong Concept ACK :)
In code where we want to rely on implicit sign changes, implicit truncations, etc we can explicitly opt-in to such on a per file or per function basis via suppressions.
-
DrahtBot commented at 4:03 PM on January 26, 2021: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #20936 (build: build fuzz tests by default by danben)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- MarcoFalke closed this on Jan 26, 2021
- MarcoFalke deleted the branch on Jan 26, 2021
-
MarcoFalke commented at 5:03 PM on January 26, 2021: member
Times out
-
practicalswift commented at 6:21 PM on January 26, 2021: contributor
@MarcoFalke In order to process the
qa-assetsinputs with-fsanitize=integerwithout timeouts I usually remove all excessively large inputs we have by usingfind qa-assets/fuzz_seed_corpus/ -type f -size +4k -delete(where4kcan be tuned). See https://github.com/bitcoin-core/qa-assets/issues/25#issuecomment-767731480. - MarcoFalke restored the branch on Jan 28, 2021
- MarcoFalke reopened this on Jan 28, 2021
-
MarcoFalke commented at 1:14 PM on January 28, 2021: member
ci passed in 1h30min
-
practicalswift commented at 9:02 PM on January 28, 2021: contributor
cr ACK faff3991a9be0ea7be31685fb46d94c212c5da34: patch looks correct
- MarcoFalke merged this on Jan 29, 2021
- MarcoFalke closed this on Jan 29, 2021
- DrahtBot locked this on Aug 16, 2022
Contributors
Labels