fuzz: Avoid designated initialization (C++20) in fuzz tests #21037

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:c++20-false-start changing 1 files +2 −2

practicalswift commented at 8:27 AM on January 30, 2021: contributor

Avoid designated initialization (C++20) in fuzz tests.

Context: #20197 (review), #20936 (review)
fuzz: Avoid designated initialization (C++20) in fuzz tests dee2d6fbf9
fanquake added the label Tests on Jan 30, 2021
MarcoFalke commented at 8:37 AM on January 30, 2021: member

cr ACK dee2d6fbf9008d0e0667b3744d847192be6ef6e0
dhruv commented at 10:42 PM on January 30, 2021: member

code review ACK dee2d6fbf9008d0e0667b3744d847192be6ef6e0

ajtowns commented at 7:03 AM on January 31, 2021: member

utACK dee2d6fbf9008d0e0667b3744d847192be6ef6e0

If you wanted to preserve the constness, could do something like the designated initializers via:

#define DES_INIT_VIA_x(TYP, CODE)     (([&]() { TYP x; {CODE} return x; })())

const in_addr v4_addr = DES_INIT_VIA_x(in_addr,
        x.s_addr = fuzzed_data_provider.ConsumeIntegral<uint32_t>();
);

MarcoFalke merged this on Jan 31, 2021
MarcoFalke closed this on Jan 31, 2021
sidhujag referenced this in commit ab208da4d8 on Feb 2, 2021
practicalswift deleted the branch on Apr 10, 2021
PastaPastaPasta referenced this in commit a83e04a6b0 on Jul 17, 2022
DrahtBot locked this on Aug 16, 2022

Contributors

Labels

Linked (view graph)

#20197 p2p: protect onions in AttemptToEvictConnection(), add eviction protection test coverage #20936 build: build fuzz tests by default