The underlying type might be implementation defined, which is probably why the sanitizer kills the fuzz tests.
Fix that by pinning the underlying type.
This refactor does not change behaviour and only affects the sanitizer in tests.
refactor: Treat ArgsManager::Flags as uint32_t explicitly #21082
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2102-unsigned changing 1 files +1 −1-
MarcoFalke commented at 6:39 PM on February 4, 2021: member
-
refactor: Treat ArgsManager::Flags as uint32_t explicitly faf3b4b533
- MarcoFalke added the label Refactoring on Feb 4, 2021
-
MarcoFalke commented at 6:40 PM on February 4, 2021: member
All ci runs fail and look like: https://cirrus-ci.com/task/5428847116025856?command=ci#L4505
-
practicalswift commented at 8:35 AM on February 5, 2021: contributor
cr ACK faf3b4b53359850e0c47e67ead1c2b6dccc55531
More generally I think we should increase our use of the fixed-width integer types. Explicit is better than implicit. Gotcha-free is better than maybe-gotcha.
- MarcoFalke merged this on Feb 5, 2021
- MarcoFalke closed this on Feb 5, 2021
- MarcoFalke deleted the branch on Feb 5, 2021
- sidhujag referenced this in commit a620ac2a4b on Feb 5, 2021
- PastaPastaPasta referenced this in commit 1c696ec744 on Jul 17, 2022
- DrahtBot locked this on Aug 16, 2022
Contributors
Labels