test: remove type: comments in favour of actual annotations #21107

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:just_use_typing_directly changing 3 files +7 −7
  1. fanquake commented at 5:33 am on February 8, 2021: member

    Now that we require Python 3.6+, we should be using variable type annotations directly rather than # type: comments.

    Also takes care of the discarded value issue in p2p_message_capture.py. See: https://github.com/bitcoin/bitcoin/pull/19509/files#r571674446.

  2. test: remove type: comments in favour of actual annotations
    Now that we require Python 3.6+, we should be using variable type
    annotations directly rather than # type: comments.
    
    Also takes care of the discarded value issue in p2p_message_capture.py.
    See: https://github.com/bitcoin/bitcoin/pull/19509/files#r571674446.
    9913419cc9
  3. fanquake added the label Tests on Feb 8, 2021
  4. MarcoFalke commented at 7:01 am on February 8, 2021: member
    review ACK 9913419cc9db5f8ce7afa0c3774468c330136064
  5. jnewbery commented at 9:48 am on February 8, 2021: member
    Code review ACK 9913419cc9db5f8ce7afa0c3774468c330136064
  6. MarcoFalke merged this on Feb 8, 2021
  7. MarcoFalke closed this on Feb 8, 2021

  8. fanquake deleted the branch on Feb 8, 2021
  9. sidhujag referenced this in commit 49e475254b on Feb 8, 2021
  10. DrahtBot locked this on Aug 16, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-03 13:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me