Unlike other repos, in our repo code review happens before merge, ideally.
Thus, rebases, solving merge conflicts and squashing should happen before review, which again happens before merge.
doc: Clarify that squashing should happen before review #21263
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2102-docSquash changing 1 files +1 −1-
MarcoFalke commented at 8:55 AM on February 22, 2021: member
-
doc: Clarify that squashing should happen before review fa1f3a26a7
- fanquake added the label Docs on Feb 22, 2021
-
MarcoFalke commented at 8:56 AM on February 22, 2021: member
(Also, squashing is no guarantee for the pull to be merged)
- theStack approved
-
theStack commented at 10:46 PM on February 22, 2021: member
ACK fa1f3a26a7541ba82a28c2a5fd09401be825c888
- fanquake approved
-
fanquake commented at 2:54 AM on February 23, 2021: member
ACK fa1f3a26a7541ba82a28c2a5fd09401be825c888
- fanquake merged this on Feb 23, 2021
- fanquake closed this on Feb 23, 2021
- sidhujag referenced this in commit ae2bab993d on Feb 23, 2021
- MarcoFalke deleted the branch on Feb 23, 2021
- fanquake locked this on Feb 24, 2021
Contributors
Labels