If the prio. will be enough after the next block don't force fees. [wallet] #2129

pull gmaxwell wants to merge 1 commits into bitcoin:master from gmaxwell:wallet_less_frequent_fees changing 1 files +4 −1

gmaxwell commented at 6:08 PM on December 26, 2012: contributor

If the user was really after the fastest possible confirmation times they would be manually setting a fee. In cases where the wallet builds a transaction with a priority that is too low to qualify as free until the next block, go ahead without a fee. Confirmation frequently takes multiple blocks even when a minimum fee is provided.
gavinandresen commented at 7:10 PM on December 26, 2012: contributor

ACK, but there should be a comment in the code explaining the +1

If the prio. will be enough after the next block don't force fees.

  If the user was really after the fastest possible confirmation times
they would be manually setting a fee. In cases where the wallet builds
a transaction with a priority that is too low to qualify as free until
the next block, go ahead without a fee.  Confirmation frequently takes
multiple blocks even when a minimum fee is provided.

d7836552e6

BitcoinPullTester commented at 8:15 AM on January 3, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/d7836552e64b1f949385f7b11836ece99f7c3d67 for binaries and test log.
sipa commented at 12:44 AM on January 6, 2013: member

ACK

in src/wallet.cpp:None in d7836552e6

1153 | @@ -1154,7 +1154,10 @@ bool CWallet::CreateTransaction(const vector<pair<CScript, int64> >& vecSend, CW
1154 |                  BOOST_FOREACH(PAIRTYPE(const CWalletTx*, unsigned int) pcoin, setCoins)
1155 |                  {
1156 |                      int64 nCredit = pcoin.first->vout[pcoin.second].nValue;
1157 | -                    dPriority += (double)nCredit * pcoin.first->GetDepthInMainChain();
1158 | +                    //The priority after the next block (depth+1) is used instead of the current,

Diapolo commented at 1:08 PM on January 10, 2013:

Can we keep a space after starting comments :)?

gavinandresen referenced this in commit 9980d118ee on Jan 14, 2013
gavinandresen merged this on Jan 14, 2013
gavinandresen closed this on Jan 14, 2013
laudney referenced this in commit 52fbb04176 on Mar 19, 2014
DrahtBot locked this on Sep 8, 2021

Contributors