guix: Bump time-machine, glibc, and linux-headers #21298

pull dongcarl wants to merge 2 commits into bitcoin:master from dongcarl:2021-02-bump-guix-and-glibc changing 2 files +4 −10
  1. dongcarl commented at 3:02 am on February 25, 2021: member

    On bumping the time-machine:

     0A few changes which are useful for us:
     1
     21. 'gnu: cross-gcc-arguments: Enable 128 bit long double for POWER9.' is
     3   now merged into master.
     42. gnutls is bumped to 3.6.15 and the temporal test failure in
     5   status-request-revoked is fixed. Note that this does not fix the case
     6   where one has installed Guix v1.2.0 and is running a substitute-less
     7   bootstrap build, since the `guix time-machine` command itself has a
     8   dependency on gnutls v3.6.12 (the one with the broken test) and will
     9   thus try to build it before attempting to jump forwards in time. This
    10   does however, mean that those who build a version of Guix that also
    11   contains this fix will not go backwards in time to build the broken
    12   gnutls v3.6.12.
    

    On bumping the rest:

    0Bump glibc and linux-headers to match those of our Gitian counterparts.
    1
    2We also require a glibc >= 2.28 for the test-symbol-check scripts to
    3work properly.
    4
    5The default BASE-GCC-FOR-LIBC also has to be bumped since glibc 2.31
    6requires a gcc >= 6.2
    

    This is a prerequisite for #20980

  2. guix: Rebase on 95aca2991b (1.2.0-12.dffc918)
    A few changes which are useful for us:
    
    1. 'gnu: cross-gcc-arguments: Enable 128 bit long double for POWER9.' is
       now merged into master.
    2. gnutls is bumped to 3.6.15 and the temporal test failure in
       status-request-revoked is fixed. Note that this does not fix the case
       where one has installed Guix v1.2.0 and is running a substitute-less
       bootstrap build, since the `guix time-machine` command itself has a
       dependency on gnutls v3.6.12 (the one with the broken test) and will
       thus try to build it before attempting to jump forwards in time. This
       does however, mean that those who build a version of Guix that also
       contains this fix will not go backwards in time to build the broken
       gnutls v3.6.12.
    65363a1bd8
  3. guix: Bump glibc and linux-headers
    Bump glibc and linux-headers to match those of our Gitian counterparts.
    
    We also require a glibc >= 2.28 for the test-symbol-check scripts to
    work properly.
    
    The default BASE-GCC-FOR-LIBC also has to be bumped since glibc 2.31
    requires a gcc >= 6.2
    c33b199456
  4. fanquake added the label Build system on Feb 25, 2021
  5. fanquake added the label Needs Guix build on Feb 25, 2021
  6. fanquake added this to the "PRs" column in a project

  7. dongcarl moved this from the "PRs" to the "Next (Not based on any other PRs)" column in a project

  8. laanwj commented at 8:17 am on February 25, 2021: member
    1. ‘gnu: cross-gcc-arguments: Enable 128 bit long double for POWER9.’ is now merged into master.

    This is about the floating point type, right, not uint128? I don’t think that’s useful to us.

    Concept ACK otherwise of course, will do a build.

  9. DrahtBot commented at 8:34 am on February 25, 2021: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #21239 (guix: Add codesignature attachment support for osx+win by dongcarl)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  10. fanquake commented at 9:15 am on February 25, 2021: member

    Builds at c33b199456e57d83c21eacd36d3c56d0a123b0d0:

     0bash-5.1# guix describe
     1Generation 6	Feb 23 2021 03:15:31	(current)
     2  guix 11f11d7
     3    repository URL: https://git.savannah.gnu.org/git/guix.git
     4    branch: master
     5    commit: 11f11d7ecb817d1421f8b5340bcced59396d8708
     6
     7bash-5.1# git rev-parse HEAD
     8c33b199456e57d83c21eacd36d3c56d0a123b0d0
     9
    10bash-5.1# find output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
    11bb2b44203b4af1625e1c9b07f4e85c22b5e337090c5e765bc574b5502cd77f92  output/bitcoin-c33b199456e5-aarch64-linux-gnu-debug.tar.gz
    126f60c9a48099338900db97095a7e583282335f8c423e0ad9eb25c33243be09e8  output/bitcoin-c33b199456e5-aarch64-linux-gnu.tar.gz
    136cd56b320a8ff3daf79d3939485bb39c0d8c55b9296e2af09739cd3e47c522b6  output/bitcoin-c33b199456e5-arm-linux-gnueabihf-debug.tar.gz
    148e26711bc2619f2fda91f0b9182ee3a8b80766b8e9c9a21cbe56a897dc87aa06  output/bitcoin-c33b199456e5-arm-linux-gnueabihf.tar.gz
    1535df83ad514e980e734680136ae58eb8ec2bd8db8147d55c66a4fc6ee4fd80d2  output/bitcoin-c33b199456e5-osx-unsigned.dmg
    166b1b69b3831b2af5702713aa28e733397d4560a173f5da86b5b42aee5a3507de  output/bitcoin-c33b199456e5-osx-unsigned.tar.gz
    17febde5b7d1844ab686716fe9532111c8628e8be31e9ca3768baf54d758f63075  output/bitcoin-c33b199456e5-osx64.tar.gz
    185768f5eda41aaf5b443f13aa81d1c78111cdb3ca606374254473e13e2ecf2efe  output/bitcoin-c33b199456e5-powerpc64-linux-gnu-debug.tar.gz
    19b6a0af9a6164e7482ccca85b55fc49d6873734667fca0ce8f620e35137712cf2  output/bitcoin-c33b199456e5-powerpc64-linux-gnu.tar.gz
    2090f8d024ca5a13cba084caba4548cb98254639e2eb7918e75862a34688e4b63a  output/bitcoin-c33b199456e5-powerpc64le-linux-gnu-debug.tar.gz
    215278e69c06416c905f0fb4f15145a707ca90d555e82c1c96b988249a1ec9b5de  output/bitcoin-c33b199456e5-powerpc64le-linux-gnu.tar.gz
    22e4900927db72cc735cd1c221671b1edcfff84236246dd1e352571f102e2173f6  output/bitcoin-c33b199456e5-riscv64-linux-gnu-debug.tar.gz
    231658fc94fce4568dd5b67af6b7a9dd2f063093273bc0f23a6255b912d600f69e  output/bitcoin-c33b199456e5-riscv64-linux-gnu.tar.gz
    24f65ef72789ab07352b5bd979ae18ff9f7a6ac01149e6f6c55329deb89516c4bf  output/bitcoin-c33b199456e5-win-unsigned.tar.gz
    258aaef7683c89f3eaca7938fed7db22b298d8604c4c684ab627425d5adfc0aabf  output/bitcoin-c33b199456e5-win64-debug.zip
    26a8bc78c942f2393186763668806a93b0e931f5d7572be4e471a77de6283ca507  output/bitcoin-c33b199456e5-win64-setup-unsigned.exe
    2785675b096b3d15e1d8ceb4b085ec13f161c323143f949a42701b9676e6e0ce7d  output/bitcoin-c33b199456e5-win64.zip
    28cc97540d65f31ee492af9d30f687f7ea93dcd18f256f5430427f370560798069  output/bitcoin-c33b199456e5-x86_64-linux-gnu-debug.tar.gz
    296565c7fc7fa6604150a0dbb54438493ae2acf1bdb1a2e846cef87894e79202ac  output/bitcoin-c33b199456e5-x86_64-linux-gnu.tar.gz
    3030a584b15c406e76e784bc81aace6db7eac0642da8c289bd3009d071510266d9  output/src/bitcoin-c33b199456e5.tar.gz
    
  11. MarcoFalke commented at 1:39 pm on February 25, 2021: member
    I am wondering what is the best way to review this. Maybe you could share a command that prints the diff of the packages we use in the build that are affected as part of the bump?
  12. dongcarl commented at 4:05 pm on February 25, 2021: member
    1. ‘gnu: cross-gcc-arguments: Enable 128 bit long double for POWER9.’ is now merged into master.

    This is about the floating point type, right, not uint128? I don’t think that’s useful to us.

    Actually, according to the comment in that commit, we do need it: “on POWER9 (little endian) glibc needs the 128 bit long double type.” I’ve also ran into this problem before when naively compiling powerpc64le glibc with a gcc that was not configured with --with-long-double-128.

  13. dongcarl commented at 4:08 pm on February 25, 2021: member

    I am wondering what is the best way to review this. Maybe you could share a command that prints the diff of the packages we use in the build that are affected as part of the bump?

    I’ve asked on #guix IRC, and there doesn’t seem to be a built-in way to do this yet. The only close approximation is:

    0$ guix time-machine --commit=6c9d16db962a6f7155571b36eced681fd2889e23 \
    1                    --url=https://github.com/dongcarl/guix.git \
    2                    -- pull --dry-run --news \
    3                            --commit=490e39ff303f4f6873a04bfb8253755bdae1b29c \
    4                            --url=https://github.com/dongcarl/guix.git
    

    However that shows the news for every single package changed between two commits…

    I will add this to my notes, as I suspect what you’re asking for can be scripted in Guile without too many modifications to Guix itself.

  14. sipa commented at 1:12 am on February 26, 2021: member

    Ubuntu 21.04 on x86_64 machine; guix 1.2.0 installed through package manager.

     0
     1$ find output/ -type f -print | fgrep c33b199456e5 | env LC_ALL=C sort | xargs sha256sum
     2bb2b44203b4af1625e1c9b07f4e85c22b5e337090c5e765bc574b5502cd77f92  output/bitcoin-c33b199456e5-aarch64-linux-gnu-debug.tar.gz
     36f60c9a48099338900db97095a7e583282335f8c423e0ad9eb25c33243be09e8  output/bitcoin-c33b199456e5-aarch64-linux-gnu.tar.gz
     46cd56b320a8ff3daf79d3939485bb39c0d8c55b9296e2af09739cd3e47c522b6  output/bitcoin-c33b199456e5-arm-linux-gnueabihf-debug.tar.gz
     58e26711bc2619f2fda91f0b9182ee3a8b80766b8e9c9a21cbe56a897dc87aa06  output/bitcoin-c33b199456e5-arm-linux-gnueabihf.tar.gz
     635df83ad514e980e734680136ae58eb8ec2bd8db8147d55c66a4fc6ee4fd80d2  output/bitcoin-c33b199456e5-osx-unsigned.dmg
     76b1b69b3831b2af5702713aa28e733397d4560a173f5da86b5b42aee5a3507de  output/bitcoin-c33b199456e5-osx-unsigned.tar.gz
     8febde5b7d1844ab686716fe9532111c8628e8be31e9ca3768baf54d758f63075  output/bitcoin-c33b199456e5-osx64.tar.gz
     95768f5eda41aaf5b443f13aa81d1c78111cdb3ca606374254473e13e2ecf2efe  output/bitcoin-c33b199456e5-powerpc64-linux-gnu-debug.tar.gz
    10b6a0af9a6164e7482ccca85b55fc49d6873734667fca0ce8f620e35137712cf2  output/bitcoin-c33b199456e5-powerpc64-linux-gnu.tar.gz
    1190f8d024ca5a13cba084caba4548cb98254639e2eb7918e75862a34688e4b63a  output/bitcoin-c33b199456e5-powerpc64le-linux-gnu-debug.tar.gz
    125278e69c06416c905f0fb4f15145a707ca90d555e82c1c96b988249a1ec9b5de  output/bitcoin-c33b199456e5-powerpc64le-linux-gnu.tar.gz
    13e4900927db72cc735cd1c221671b1edcfff84236246dd1e352571f102e2173f6  output/bitcoin-c33b199456e5-riscv64-linux-gnu-debug.tar.gz
    141658fc94fce4568dd5b67af6b7a9dd2f063093273bc0f23a6255b912d600f69e  output/bitcoin-c33b199456e5-riscv64-linux-gnu.tar.gz
    15f65ef72789ab07352b5bd979ae18ff9f7a6ac01149e6f6c55329deb89516c4bf  output/bitcoin-c33b199456e5-win-unsigned.tar.gz
    168aaef7683c89f3eaca7938fed7db22b298d8604c4c684ab627425d5adfc0aabf  output/bitcoin-c33b199456e5-win64-debug.zip
    17a8bc78c942f2393186763668806a93b0e931f5d7572be4e471a77de6283ca507  output/bitcoin-c33b199456e5-win64-setup-unsigned.exe
    1885675b096b3d15e1d8ceb4b085ec13f161c323143f949a42701b9676e6e0ce7d  output/bitcoin-c33b199456e5-win64.zip
    19cc97540d65f31ee492af9d30f687f7ea93dcd18f256f5430427f370560798069  output/bitcoin-c33b199456e5-x86_64-linux-gnu-debug.tar.gz
    206565c7fc7fa6604150a0dbb54438493ae2acf1bdb1a2e846cef87894e79202ac  output/bitcoin-c33b199456e5-x86_64-linux-gnu.tar.gz
    2130a584b15c406e76e784bc81aace6db7eac0642da8c289bd3009d071510266d9  output/src/bitcoin-c33b199456e5.tar.gz
    
  15. laanwj commented at 3:19 pm on February 26, 2021: member

    My build output. Checked they match @sipa and @fanquake’s

     0bb2b44203b4af1625e1c9b07f4e85c22b5e337090c5e765bc574b5502cd77f92  output/bitcoin-c33b199456e5-aarch64-linux-gnu-debug.tar.gz
     16f60c9a48099338900db97095a7e583282335f8c423e0ad9eb25c33243be09e8  output/bitcoin-c33b199456e5-aarch64-linux-gnu.tar.gz
     26cd56b320a8ff3daf79d3939485bb39c0d8c55b9296e2af09739cd3e47c522b6  output/bitcoin-c33b199456e5-arm-linux-gnueabihf-debug.tar.gz
     38e26711bc2619f2fda91f0b9182ee3a8b80766b8e9c9a21cbe56a897dc87aa06  output/bitcoin-c33b199456e5-arm-linux-gnueabihf.tar.gz
     435df83ad514e980e734680136ae58eb8ec2bd8db8147d55c66a4fc6ee4fd80d2  output/bitcoin-c33b199456e5-osx-unsigned.dmg
     56b1b69b3831b2af5702713aa28e733397d4560a173f5da86b5b42aee5a3507de  output/bitcoin-c33b199456e5-osx-unsigned.tar.gz
     6febde5b7d1844ab686716fe9532111c8628e8be31e9ca3768baf54d758f63075  output/bitcoin-c33b199456e5-osx64.tar.gz
     75768f5eda41aaf5b443f13aa81d1c78111cdb3ca606374254473e13e2ecf2efe  output/bitcoin-c33b199456e5-powerpc64-linux-gnu-debug.tar.gz
     8b6a0af9a6164e7482ccca85b55fc49d6873734667fca0ce8f620e35137712cf2  output/bitcoin-c33b199456e5-powerpc64-linux-gnu.tar.gz
     990f8d024ca5a13cba084caba4548cb98254639e2eb7918e75862a34688e4b63a  output/bitcoin-c33b199456e5-powerpc64le-linux-gnu-debug.tar.gz
    105278e69c06416c905f0fb4f15145a707ca90d555e82c1c96b988249a1ec9b5de  output/bitcoin-c33b199456e5-powerpc64le-linux-gnu.tar.gz
    11e4900927db72cc735cd1c221671b1edcfff84236246dd1e352571f102e2173f6  output/bitcoin-c33b199456e5-riscv64-linux-gnu-debug.tar.gz
    121658fc94fce4568dd5b67af6b7a9dd2f063093273bc0f23a6255b912d600f69e  output/bitcoin-c33b199456e5-riscv64-linux-gnu.tar.gz
    13f65ef72789ab07352b5bd979ae18ff9f7a6ac01149e6f6c55329deb89516c4bf  output/bitcoin-c33b199456e5-win-unsigned.tar.gz
    148aaef7683c89f3eaca7938fed7db22b298d8604c4c684ab627425d5adfc0aabf  output/bitcoin-c33b199456e5-win64-debug.zip
    15a8bc78c942f2393186763668806a93b0e931f5d7572be4e471a77de6283ca507  output/bitcoin-c33b199456e5-win64-setup-unsigned.exe
    1685675b096b3d15e1d8ceb4b085ec13f161c323143f949a42701b9676e6e0ce7d  output/bitcoin-c33b199456e5-win64.zip
    17cc97540d65f31ee492af9d30f687f7ea93dcd18f256f5430427f370560798069  output/bitcoin-c33b199456e5-x86_64-linux-gnu-debug.tar.gz
    186565c7fc7fa6604150a0dbb54438493ae2acf1bdb1a2e846cef87894e79202ac  output/bitcoin-c33b199456e5-x86_64-linux-gnu.tar.gz
    1930a584b15c406e76e784bc81aace6db7eac0642da8c289bd3009d071510266d9  output/src/bitcoin-c33b199456e5.tar.gz
    
  16. sipa commented at 9:18 pm on February 26, 2021: member
    My Debian VM with guix-master-branch-built-from-source has a mismatch on output/bitcoin-c33b199456e5-osx-unsigned.tar.gz. This appears to be purely due to codesign_allocate and pagestuff differing, which are files we don’t need anymore (right, @achow101?). @dongcarl is looking into what is causing the difference.
  17. achow101 commented at 9:32 pm on February 26, 2021: member
    Since even gitian is using signapple, and using the version that doesn’t rely on codesign_allocate, codesign_allocate and pagestuff are entirely unnecessary now.
  18. DrahtBot commented at 6:35 pm on February 28, 2021: member

    Guix builds

    File commit 5ba5becbb5d8c794efe579caeea7eea64f895a13(master) commit d45a567fe6db37233ed42af41e06f83c358e07db(master and this pull)
    *-aarch64-linux-gnu-debug.tar.gz 5f74435231e17632... 9bbcd3416285050b...
    *-aarch64-linux-gnu.tar.gz a71e54c9b627c295... 5158fcf379a24458...
    *-arm-linux-gnueabihf-debug.tar.gz adf10a3ead42e9ba... a7b70cb21514f233...
    *-arm-linux-gnueabihf.tar.gz 382c9a8f3d796ba3... 156cbbcfa4f6877f...
    *-osx-unsigned.dmg 751e49d27e9dccd4... 6101e0e8d010ca70...
    *-osx-unsigned.tar.gz 4a9c99658847a4cc... 8875444fa9d290e1...
    *-osx64.tar.gz 6151d4880a9f291d... b21c4af729caf48f...
    *-powerpc64-linux-gnu-debug.tar.gz 4b78706c37822742... e151deee4853e646...
    *-powerpc64-linux-gnu.tar.gz 9a4d5bf59567ef5d... e0e08931d3484a99...
    *-powerpc64le-linux-gnu-debug.tar.gz f2e6b7c6ab0370e4... da66361b3d52385f...
    *-powerpc64le-linux-gnu.tar.gz 335d84ca8cba4211... ab2f5fffd3c270bc...
    *-riscv64-linux-gnu-debug.tar.gz e7eb25c4573e8cce... 313b0ffba6c45eae...
    *-riscv64-linux-gnu.tar.gz f41946c7ae5c3350... 5d2bc853455ed879...
    *-win-unsigned.tar.gz 243be5c40837f82e... 7e3c6d4e9544ea4d...
    *-win64-debug.zip 5f954f624f268072... 1b5a81d3e94239c6...
    *-win64-setup-unsigned.exe 780312bdd9940cfb... d99a842436eaf144...
    *-win64.zip 2e3e1e98973df7de... 6b59e4f9cc960965...
    *-x86_64-linux-gnu-debug.tar.gz 83181be936b817e5... 9371d69561cee941...
    *-x86_64-linux-gnu.tar.gz b79145fbd0267974... 8fd197adf6ea9b58...
    *.tar.gz 0784b3d773e5761f... 38b1ff0110161e67...
    guix_build.log 752e44aa2f570812... 1b255b82545af90f...
    guix_build.log.diff 4754f5613e222976...
  19. DrahtBot removed the label Needs Guix build on Feb 28, 2021
  20. fanquake approved
  21. fanquake commented at 1:32 am on March 2, 2021: member
    ACK c33b199456e57d83c21eacd36d3c56d0a123b0d0 - I think going ahead with this now and to sycn back up to gitian is fine. It will also unblock #20980. Potential code signing related issues can be sorted out in #21239 and later PRs.
  22. dongcarl commented at 1:35 am on March 2, 2021: member

    I think this PR is ready for merge, I’ve noted two things that needs attention that are separate from this PR:

    1. Native depends binaries have a non-reproducibility in their RUNPATH section, most likely due to Guix’s ld wrapper for native binaries not being disabled for darwin. This does not affect us at all once we remove the two tools from our unsigned tarball and use applesign, but I will investigate with upstream.
    2. Nice-to-have: a way to review derivation changes as a result of time-machine bumps but limited to one manifest and not the whole Guix package set.
  23. fanquake merged this on Mar 2, 2021
  24. fanquake closed this on Mar 2, 2021

  25. fanquake moved this from the "Next (Not based on any other PRs)" to the "Done" column in a project

  26. hebasto commented at 10:55 am on March 2, 2021: member
     0$ lsb_release -dc
     1Description:	Ubuntu Hirsute Hippo (development branch)
     2Codename:	hirsute
     3$ dpkg --status guix | head -9
     4Package: guix
     5Status: install ok installed
     6Priority: optional
     7Section: admin
     8Installed-Size: 261656
     9Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
    10Architecture: amd64
    11Multi-Arch: foreign
    12Version: 1.2.0-3
    13$ git clean -xdff --exclude='/depends/SDKs/*'
    14$ time ./contrib/guix/guix-build.sh
    15...
    16real	237m47,159s
    17user	514m29,652s
    18sys	45m14,712s
    19$ find output -type f -print0 | sort -z | xargs -r0 sha256sum
    20bb2b44203b4af1625e1c9b07f4e85c22b5e337090c5e765bc574b5502cd77f92  output/bitcoin-c33b199456e5-aarch64-linux-gnu-debug.tar.gz
    216f60c9a48099338900db97095a7e583282335f8c423e0ad9eb25c33243be09e8  output/bitcoin-c33b199456e5-aarch64-linux-gnu.tar.gz
    226cd56b320a8ff3daf79d3939485bb39c0d8c55b9296e2af09739cd3e47c522b6  output/bitcoin-c33b199456e5-arm-linux-gnueabihf-debug.tar.gz
    238e26711bc2619f2fda91f0b9182ee3a8b80766b8e9c9a21cbe56a897dc87aa06  output/bitcoin-c33b199456e5-arm-linux-gnueabihf.tar.gz
    24febde5b7d1844ab686716fe9532111c8628e8be31e9ca3768baf54d758f63075  output/bitcoin-c33b199456e5-osx64.tar.gz
    2535df83ad514e980e734680136ae58eb8ec2bd8db8147d55c66a4fc6ee4fd80d2  output/bitcoin-c33b199456e5-osx-unsigned.dmg
    26095fb20b17783a0672c3c742721de2df9348299ce98204e63eb9b20922211eea  output/bitcoin-c33b199456e5-osx-unsigned.tar.gz
    2790f8d024ca5a13cba084caba4548cb98254639e2eb7918e75862a34688e4b63a  output/bitcoin-c33b199456e5-powerpc64le-linux-gnu-debug.tar.gz
    285278e69c06416c905f0fb4f15145a707ca90d555e82c1c96b988249a1ec9b5de  output/bitcoin-c33b199456e5-powerpc64le-linux-gnu.tar.gz
    295768f5eda41aaf5b443f13aa81d1c78111cdb3ca606374254473e13e2ecf2efe  output/bitcoin-c33b199456e5-powerpc64-linux-gnu-debug.tar.gz
    30b6a0af9a6164e7482ccca85b55fc49d6873734667fca0ce8f620e35137712cf2  output/bitcoin-c33b199456e5-powerpc64-linux-gnu.tar.gz
    31e4900927db72cc735cd1c221671b1edcfff84236246dd1e352571f102e2173f6  output/bitcoin-c33b199456e5-riscv64-linux-gnu-debug.tar.gz
    321658fc94fce4568dd5b67af6b7a9dd2f063093273bc0f23a6255b912d600f69e  output/bitcoin-c33b199456e5-riscv64-linux-gnu.tar.gz
    338aaef7683c89f3eaca7938fed7db22b298d8604c4c684ab627425d5adfc0aabf  output/bitcoin-c33b199456e5-win64-debug.zip
    34a8bc78c942f2393186763668806a93b0e931f5d7572be4e471a77de6283ca507  output/bitcoin-c33b199456e5-win64-setup-unsigned.exe
    3585675b096b3d15e1d8ceb4b085ec13f161c323143f949a42701b9676e6e0ce7d  output/bitcoin-c33b199456e5-win64.zip
    36f65ef72789ab07352b5bd979ae18ff9f7a6ac01149e6f6c55329deb89516c4bf  output/bitcoin-c33b199456e5-win-unsigned.tar.gz
    37cc97540d65f31ee492af9d30f687f7ea93dcd18f256f5430427f370560798069  output/bitcoin-c33b199456e5-x86_64-linux-gnu-debug.tar.gz
    386565c7fc7fa6604150a0dbb54438493ae2acf1bdb1a2e846cef87894e79202ac  output/bitcoin-c33b199456e5-x86_64-linux-gnu.tar.gz
    3930a584b15c406e76e784bc81aace6db7eac0642da8c289bd3009d071510266d9  output/src/bitcoin-c33b199456e5.tar.gz
    
  27. sidhujag referenced this in commit f1e0f4f0d7 on Mar 2, 2021
  28. hebasto commented at 4:56 am on June 27, 2021: member

    We also require a glibc >= 2.28 for the test-symbol-check scripts to work properly.

    Does this sound a little dubious just to me?

  29. dongcarl commented at 6:50 pm on June 28, 2021: member

    @hebasto Sorry, I should have been more specific, here is the check that fails: https://github.com/bitcoin/bitcoin/blob/3f56ef7bef22f0c8c94ad7e401d50b188dae2cbe/contrib/devtools/test-symbol-check.py#L12-L45

    The call to symbol-check.py is supposed to return an error code because renameat2 is referenced" https://github.com/bitcoin/bitcoin/blob/3f56ef7bef22f0c8c94ad7e401d50b188dae2cbe/contrib/devtools/test-symbol-check.py#L14

    but when building against a toolchain with glibc < 2.28, the compilation will fail earlier: https://github.com/bitcoin/bitcoin/blob/3f56ef7bef22f0c8c94ad7e401d50b188dae2cbe/contrib/devtools/test-symbol-check.py#L13

  30. DrahtBot locked this on Aug 18, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me