build: Make AM_CONDITIONAL([ENABLE_EXTERNAL_SIGNER]) unconditional #21339

1. 
   hebasto commented at 5:08 pm on March 2, 2021: member

   #16546 introduced a regression in the configure:

   0$ ./autogen.sh
   1$ ./configure --disable-wallet --without-utils --without-daemon --without-gui --disable-tests --disable-bench
   2...
   3checking whether to build test_bitcoin... no
   4checking whether to reduce exports... no
   5checking that generated files are newer than configure... done
   6configure: error: conditional "ENABLE_EXTERNAL_SIGNER" was never defined.
   7Usually this means the macro was only invoked conditionally.
   

   This PR fixes this bug, and refactors indentation to make easier to spot similar bugs in the future.

2. build, refactor: Fix indentation for if..then..fi

   This makes easier to spot conditional macros.

   9fef209945
3. build: Make AM_CONDITIONAL([ENABLE_EXTERNAL_SIGNER]) unconditional

   This change fixes an error when the value of the "use_boost" variable is
   equal to "no".

   a4128138b4
4. 
   hebasto commented at 5:10 pm on March 2, 2021: member

   cc @Sjors
5. 
   Sjors commented at 5:27 pm on March 2, 2021: member

   utACK a4128138b4837baadde75247cd4fd8ea463b7df5
6. DrahtBot added the label Build system on Mar 2, 2021
7. MarcoFalke added the label Needs gitian build on Mar 2, 2021
8. MarcoFalke added the label Needs Guix build on Mar 2, 2021
9. fanquake approved
10. 
    fanquake commented at 2:52 am on March 3, 2021: member

    ACK a4128138b4837baadde75247cd4fd8ea463b7df5 - this fixes the bug described, and improves readability.
11. fanquake merged this on Mar 3, 2021
12. fanquake closed this on Mar 3, 2021

    ---

13. hebasto deleted the branch on Mar 3, 2021
14. MarcoFalke removed the label Needs Guix build on Mar 3, 2021
15. MarcoFalke removed the label Needs gitian build on Mar 3, 2021
16. sidhujag referenced this in commit 6dcbd09a88 on Mar 3, 2021
17. DrahtBot locked this on Aug 16, 2022

Contributors
hebasto Sjors fanquake

Labels
Build system