build: Make AM_CONDITIONAL([ENABLE_EXTERNAL_SIGNER]) unconditional #21339

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:210302-signer changing 1 files +51 −51

hebasto commented at 5:08 PM on March 2, 2021: member

#16546 introduced a regression in the configure:

$ ./autogen.sh
$ ./configure --disable-wallet --without-utils --without-daemon --without-gui --disable-tests --disable-bench
...
checking whether to build test_bitcoin... no
checking whether to reduce exports... no
checking that generated files are newer than configure... done
configure: error: conditional "ENABLE_EXTERNAL_SIGNER" was never defined.
Usually this means the macro was only invoked conditionally.

This PR fixes this bug, and refactors indentation to make easier to spot similar bugs in the future.

build, refactor: Fix indentation for if..then..fi
This makes easier to spot conditional macros.
9fef209945

build: Make AM_CONDITIONAL([ENABLE_EXTERNAL_SIGNER]) unconditional

This change fixes an error when the value of the "use_boost" variable is
equal to "no".

a4128138b4

hebasto commented at 5:10 PM on March 2, 2021: member

cc @Sjors
Sjors commented at 5:27 PM on March 2, 2021: member

utACK a4128138b4837baadde75247cd4fd8ea463b7df5
DrahtBot added the label Build system on Mar 2, 2021
MarcoFalke added the label Needs gitian build on Mar 2, 2021
MarcoFalke added the label Needs Guix build on Mar 2, 2021
fanquake approved
fanquake commented at 2:52 AM on March 3, 2021: member

ACK a4128138b4837baadde75247cd4fd8ea463b7df5 - this fixes the bug described, and improves readability.
fanquake merged this on Mar 3, 2021
fanquake closed this on Mar 3, 2021
hebasto deleted the branch on Mar 3, 2021
MarcoFalke removed the label Needs Guix build on Mar 3, 2021
MarcoFalke removed the label Needs gitian build on Mar 3, 2021
sidhujag referenced this in commit 6dcbd09a88 on Mar 3, 2021
DrahtBot locked this on Aug 16, 2022

Contributors

Labels

Linked (view graph)

#16546 External signer support - Wallet Box edition