guix: guix doesn’t like x86_64-pc-linux-gnu #21347

issue fanquake openend this issue on March 3, 2021
  1. fanquake commented at 4:18 am on March 3, 2021: member

    This has caught me out more than once. If you try and perform a Guix build with HOSTS="x86_64-pc-linux-gnu" ./contrib/guix/guix-build.sh, it doesn’t work, and the build script just “dies”. The problem is here:

    https://github.com/bitcoin/bitcoin/blob/4f223e93e9c097c96a1655f9125aec463892da9c/contrib/guix/libexec/build.sh#L147-L158

    There is no x86_64-pc-linux-gnu case, so we just exit. I ended up using x86_64-pc-linux-gnu after copy-pasting from the triplets listed in the depends readme.

  2. fanquake added the label Bug on Mar 3, 2021
  3. fanquake added the label Build system on Mar 3, 2021
  4. fanquake assigned dongcarl on Mar 3, 2021
  5. dongcarl commented at 7:37 pm on March 3, 2021: contributor
    I don’t believe we ever supported x86_64-pc-linux-gnu for Gitian builds… Perhaps we can just update the triplet in the depends README? Specifying pc as the vendor seems meaningless to me 🤷‍♂️
  6. fanquake commented at 3:44 am on March 4, 2021: member

    Perhaps we can just update the triplet in the depends README? Specifying pc as the vendor seems meaningless to me 🤷‍♂️

    I’m not sure it’s quite that simple, unless we make it a requirement to pass HOST=x86_64-linux-gnu when building depends on/for Linux.

    When we construct build_os and host_os, we are using the vendor: https://github.com/bitcoin/bitcoin/blob/47b99ab1a9e918022ea13f54765f5b4e6aad6140/depends/Makefile#L72-L74

    https://github.com/bitcoin/bitcoin/blob/47b99ab1a9e918022ea13f54765f5b4e6aad6140/depends/Makefile#L82-L83

    So anyone running make -C depends is still going to end up with /bitcoin/depends/x86_64-pc-linux-gnu if HOST isn’t set.

    Ultimately this comes from config.guess:

    0./depends/config.guess
    1x86_64-pc-linux-gnu
    
  7. fanquake commented at 11:37 am on July 26, 2022: member
    Going to close this for now. No-longer that big of an issue.
  8. fanquake closed this on Jul 26, 2022

  9. bitcoin locked this on Jul 26, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-20 03:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me